Skip to content

Conversation

@Yicong-Huang
Copy link
Contributor

@Yicong-Huang Yicong-Huang commented Oct 13, 2025

We have been using a mixed of logs/, ../log/ and log/ to store logs. This PR unifies them to use logs/ directory.

follows up on #3879

Copilot AI review requested due to automatic review settings October 13, 2025 04:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR standardizes log file storage paths across all services to use a consistent logs/ directory structure. Previously, the codebase was using inconsistent paths including ../log/, log/, and logs/.

  • Updates configuration files to use logs/ as the unified log directory
  • Changes apply to both current log files and archived log filename patterns
  • Affects multiple services including amber-server, access-control-service, and computing-unit-master

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
common/config/src/main/resources/application.conf Updates comment example to use logs/ directory
amber/src/main/resources/web-config.yml Changes access and amber-server log paths from ../log/ to logs/
amber/src/main/resources/texera-compiling-service-web-config.yml Updates access and workflow compiling service log paths to logs/
amber/src/main/resources/logback.xml Changes amber-worker log file and pattern paths to logs/
amber/src/main/resources/computing-unit-master-config.yml Updates computing-unit-master log path to logs/
access-control-service/src/main/resources/logback.xml Changes access-control-service log paths to logs/

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Yicong-Huang Yicong-Huang self-assigned this Oct 13, 2025
Copy link
Contributor

@bobbai00 bobbai00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Yicong-Huang Yicong-Huang merged commit 6e86784 into main Oct 13, 2025
12 checks passed
@Yicong-Huang Yicong-Huang deleted the fix/use-logs-for-all-services branch October 13, 2025 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants