Skip to content

fix: use logs/ for all services #3887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 13, 2025
Merged

fix: use logs/ for all services #3887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7073b8c
fix: use logs/
Yicong-Huang Oct 13, 2025
c974984
chore: ignore logs/
Yicong-Huang Oct 13, 2025
27d4b49
Merge branch 'main' into fix/use-logs-for-all-services
Yicong-Huang Oct 13, 2025
c00f739
Merge branch 'main' into fix/use-logs-for-all-services
Yicong-Huang Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ rebel.xml
*.log.gz

# Ignoring the entire log folder
log/
logs/

# Ignoring package-lock.json
package-lock.json
Expand Down
4 changes: 2 additions & 2 deletions access-control-service/src/main/resources/logback.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@


<appender name="FILE" class="ch.qos.logback.core.rolling.RollingFileAppender">
<file>../log/access-control-service.log</file>
<file>logs/access-control-service.log</file>
<immediateFlush>true</immediateFlush>
<rollingPolicy class="ch.qos.logback.core.rolling.TimeBasedRollingPolicy">
<fileNamePattern>../log/access-control-service-%d{yyyy-MM-dd}.log.gz</fileNamePattern>
<fileNamePattern>logs/access-control-service-%d{yyyy-MM-dd}.log.gz</fileNamePattern>
</rollingPolicy>
<encoder>
<pattern>[%date{ISO8601}] [%level] [%logger] [%thread] - %msg %n</pattern>
Expand Down
2 changes: 1 addition & 1 deletion amber/src/main/resources/computing-unit-master-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ logging:
- type: console
logFormat: "[%date{ISO8601}] [%level] [%logger] [%thread] - %msg %n"
- type: file
currentLogFilename: ../log/computing-unit-master.log
currentLogFilename: logs/computing-unit-master.log
threshold: ALL
queueSize: 512
discardingThreshold: 0
Expand Down
4 changes: 2 additions & 2 deletions amber/src/main/resources/logback.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,10 @@


<appender name="FILE" class="ch.qos.logback.core.rolling.RollingFileAppender">
<file>../log/amber-worker.log</file>
<file>logs/amber-worker.log</file>
<immediateFlush>true</immediateFlush>
<rollingPolicy class="ch.qos.logback.core.rolling.TimeBasedRollingPolicy">
<fileNamePattern>../log/amber-worker-%d{yyyy-MM-dd}.log.gz</fileNamePattern>
<fileNamePattern>logs/amber-worker-%d{yyyy-MM-dd}.log.gz</fileNamePattern>
</rollingPolicy>
<encoder>
<pattern>[%date{ISO8601}] [%level] [%logger] [%thread] - %msg %n</pattern>
Expand Down
6 changes: 3 additions & 3 deletions amber/src/main/resources/texera-compiling-service-web-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,12 @@ server:
appenders:
- type: console
- type: file
currentLogFilename: ../log/access.log
currentLogFilename: logs/access.log
threshold: ALL
queueSize: 512
discardingThreshold: 0
archive: true
archivedLogFilenamePattern: ../log/access-%d{yyyy-MM-dd}.log.gz
archivedLogFilenamePattern: logs/access-%d{yyyy-MM-dd}.log.gz
archivedFileCount: 7
bufferSize: 8KiB
immediateFlush: true
Expand All @@ -48,7 +48,7 @@ logging:
- type: console
logFormat: "[%date{ISO8601}] [%level] [%logger] [%thread] - %msg %n"
- type: file
currentLogFilename: ../log/texera-workflow-compiling-service.log
currentLogFilename: logs/texera-workflow-compiling-service.log
threshold: ALL
queueSize: 512
discardingThreshold: 0
Expand Down
6 changes: 3 additions & 3 deletions amber/src/main/resources/web-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,12 @@ server:
appenders:
- type: console
- type: file
currentLogFilename: ../log/access.log
currentLogFilename: logs/access.log
threshold: ALL
queueSize: 512
discardingThreshold: 0
archive: true
archivedLogFilenamePattern: ../log/access-%d{yyyy-MM-dd}.log.gz
archivedLogFilenamePattern: logs/access-%d{yyyy-MM-dd}.log.gz
archivedFileCount: 7
bufferSize: 8KiB
immediateFlush: true
Expand All @@ -48,7 +48,7 @@ logging:
- type: console
logFormat: "[%date{ISO8601}] [%level] [%logger] [%thread] - %msg %n"
- type: file
currentLogFilename: ../log/amber-server.log
currentLogFilename: logs/amber-server.log
threshold: ALL
queueSize: 512
discardingThreshold: 0
Expand Down
2 changes: 1 addition & 1 deletion common/config/src/main/resources/application.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ web-server {
fault-tolerance {
# URI for storage, empty to disable logging.
# Use absolute path only. for local file system, $AMBER_FOLDER will be interpolated to Amber folder path.
# e.g. use "file://$AMBER_FOLDER/../log/recovery-logs/" for local logging.
# e.g. use "file://$AMBER_FOLDER/logs/recovery-logs/" for local logging.
log-storage-uri = ""
log-storage-uri = ${?FAULT_TOLERANCE_LOG_STORAGE_URI}

Expand Down
Loading