TIKA-4540 -- First steps - WIP #2390
Conversation
| <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd"> | ||
| <modelVersion>4.0.0</modelVersion> | ||
| <project xmlns="http://maven.apache.org/POM/4.1.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.1.0 https://maven.apache.org/xsd/maven-4.1.0.xsd"> | ||
| <modelVersion>4.1.0</modelVersion> |
There was a problem hiding this comment.
No need for model version change, Maven 4 is happy with model 4.0 as well. Worth keeping it at model version 4.0 if you want to keep both, ability to build with Maven 3 and Maven 4. Once only Maven 4 is used, you can up model as well (of course, if you do want new features and insist on Maven4-only, model change is okay too, but then Maven 3 is not usable anymore to build Tika)
There was a problem hiding this comment.
That was done automatically by mvnup
There was a problem hiding this comment.
Now, I see because of the settings I used, based on the documentation for upgrading.
| <modules> | ||
| <module>tika-bundle-standard</module> | ||
| </modules> | ||
| <subprojects> |
There was a problem hiding this comment.
IF you remain on model 4.0 (to allow both, use of Maven 3 and Maven 4 to build Tika) undo this.
There was a problem hiding this comment.
that was done by mvnup automatically. Should I undo that throughout?
|
@gnodet ping @tballison did you use |
|
I tried to update to use nisse, and i"m still getting the error. I set I acknowledge that I may have messed up both fixes...lol... Thank you @cstamas ! |
Y. I tried to follow directions. 🤣 |
So if you upgrade to model 4.1.0, you need Maven 4. The build error comes from Maven 3 not supporting this model version. |
|
The point of this is to see if we can upgrade once 4.0.0 is released. I'm not expecting a clean ci/cd build atm. Thank you, again! |
|
@tballison see #2391 |
|
Awesome. Merged. Thank you @cstamas ! |
|
The last change makes it fail on our CI: [INFO] --- protobuf:0.6.1:compile (default) @ tika-grpc --- looking for that error message, I see that it suggests to add exactly the segment that was removed in the tika-grpc pom.xml |
|
Oops I see now that this was mentioned in the JIRA ticket, that this plugin no longer works. |
This is the set of minimal changes to make the build work with Maven 4 Changes: * drop unmaintained extension, replace with Nisse * move ossindex plugin to verify (was at validate) -- makes dep resolution mandatory * fix using user properties the P2 repo without repo.id (makes Maven 4 fail) (cherry picked from commit a8e7f9f)
|
@THausherr sorry for the noise. I just merged @cstamas 's PR into this branch and I got a local clean build with maven 4.0.0-rc5. Once maven 4.0.0 is released, we can merge this and update our ci/cd? Unless there's an easy way to configure 4.0.0-rc5 for a separate build now? |
4 participants
Thanks for your contribution to Apache Tika! Your help is appreciated!
Before opening the pull request, please verify that
TIKA-XXXX)[TIKA-XXXX] Issue or pull request title)mvn clean testmainbranch. If there are conflicts, please try to rebase the pull request branch on top of a freshly pulledmainbranchtika-bom/pom.xml.We will be able to faster integrate your pull request if these conditions are met. If you have any questions how to fix your problem or about using Tika in general, please sign up for the Tika mailing list. Thanks!