-
Notifications
You must be signed in to change notification settings - Fork 886
TIKA-4540 -- First steps - WIP #2390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
d3c9a15
9b4a0ad
4bd175b
bebc380
eb1ec8f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <extensions> | ||
| <extension> | ||
| <groupId>eu.maveniverse.maven.nisse</groupId> | ||
| <artifactId>extension</artifactId> | ||
| <version>0.6.2</version> | ||
| </extension> | ||
| </extensions> |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| -D | ||
| nisse.compat.osDetector | ||
| # fix for nlp module | ||
| -D | ||
| eclipseP2RepoId=invalid |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,24 +17,23 @@ | |
| specific language governing permissions and limitations | ||
| under the License. | ||
| --> | ||
| <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd"> | ||
| <project xmlns="http://maven.apache.org/POM/4.1.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.1.0 https://maven.apache.org/xsd/maven-4.1.0.xsd"> | ||
| <parent> | ||
| <artifactId>tika-parent</artifactId> | ||
| <groupId>org.apache.tika</groupId> | ||
| <version>4.0.0-SNAPSHOT</version> | ||
| <relativePath>../tika-parent/pom.xml</relativePath> | ||
| </parent> | ||
| <modelVersion>4.0.0</modelVersion> | ||
| <modelVersion>4.1.0</modelVersion> | ||
|
|
||
| <artifactId>tika-bundles</artifactId> | ||
| <version>4.0.0-SNAPSHOT</version> | ||
| <name>Apache Tika bundles module</name> | ||
|
|
||
| <packaging>pom</packaging> | ||
|
|
||
| <modules> | ||
| <module>tika-bundle-standard</module> | ||
| </modules> | ||
| <subprojects> | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. IF you remain on model 4.0 (to allow both, use of Maven 3 and Maven 4 to build Tika) undo this.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. that was done by |
||
| <subproject>tika-bundle-standard</subproject> | ||
| </subprojects> | ||
|
|
||
| <build> | ||
| <plugins> | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for model version change, Maven 4 is happy with model 4.0 as well. Worth keeping it at model version 4.0 if you want to keep both, ability to build with Maven 3 and Maven 4. Once only Maven 4 is used, you can up model as well (of course, if you do want new features and insist on Maven4-only, model change is okay too, but then Maven 3 is not usable anymore to build Tika)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was done automatically by
mvnupThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now, I see because of the settings I used, based on the documentation for upgrading.