Skip to content

LSan: Fix memory leak of test_X509HostnameValidator #10161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
masaori335 merged 1 commit into from
Aug 15, 2023
Merged

LSan: Fix memory leak of test_X509HostnameValidator #10161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/tscore/unit_tests/test_X509HostnameValidator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@
#include "tscore/ink_queue.h"
#include "tscore/X509HostnameValidator.h"

#include "tscpp/util/PostScript.h"

// clang-format off

// A simple certificate for CN=test.sslheaders.trafficserver.apache.org.
Expand Down Expand Up @@ -98,13 +100,17 @@ static X509 *
load_cert_from_string(const char *cert_string)
{
BIO *bio = BIO_new_mem_buf((void *)cert_string, -1);
ts::PostScript bio_defer([&]() -> void { BIO_free(bio); });

return PEM_read_bio_X509(bio, nullptr, nullptr, nullptr);
}

TEST_CASE("CN_match", "[libts][X509HostnameValidator]")
{
char *matching;
X509 *x = load_cert_from_string(test_certificate_cn);
ts::PostScript x_defer([&]() -> void { X509_free(x); });

REQUIRE(x != nullptr);
REQUIRE(validate_hostname(x, (unsigned char *)test_certificate_cn_name, false, &matching) == true);
REQUIRE(strcmp(test_certificate_cn_name, matching) == 0);
Expand All @@ -115,6 +121,8 @@ TEST_CASE("CN_match", "[libts][X509HostnameValidator]")
TEST_CASE("bad_wildcard_SANs", "[libts][X509HostnameValidator]")
{
X509 *x = load_cert_from_string(test_certificate_bad_sans);
ts::PostScript x_defer([&]() -> void { X509_free(x); });

REQUIRE(x != nullptr);
REQUIRE(validate_hostname(x, (unsigned char *)"something.or.other", false, nullptr) == false);
REQUIRE(validate_hostname(x, (unsigned char *)"a.b.c", false, nullptr) == false);
Expand All @@ -127,6 +135,8 @@ TEST_CASE("wildcard_SAN_and_CN", "[libts][X509HostnameValidator]")
{
char *matching;
X509 *x = load_cert_from_string(test_certificate_cn_and_SANs);
ts::PostScript x_defer([&]() -> void { X509_free(x); });

REQUIRE(x != nullptr);
REQUIRE(validate_hostname(x, (unsigned char *)test_certificate_cn_name, false, &matching) == true);
REQUIRE(strcmp(test_certificate_cn_name, matching) == 0);
Expand All @@ -143,6 +153,8 @@ TEST_CASE("IDNA_hostnames", "[libts][X509HostnameValidator]")
{
char *matching;
X509 *x = load_cert_from_string(test_certificate_cn_and_SANs);
ts::PostScript x_defer([&]() -> void { X509_free(x); });

REQUIRE(x != nullptr);
REQUIRE(validate_hostname(x, (unsigned char *)"xn--foobar.trafficserver.org", false, &matching) == true);
REQUIRE(strcmp("*.trafficserver.org", matching) == 0);
Expand All @@ -156,6 +168,8 @@ TEST_CASE("middle_label_match", "[libts][X509HostnameValidator]")
{
char *matching;
X509 *x = load_cert_from_string(test_certificate_cn_and_SANs);
ts::PostScript x_defer([&]() -> void { X509_free(x); });

REQUIRE(x != nullptr);
REQUIRE(validate_hostname(x, (unsigned char *)"foosomething.trafficserver.com", false, &matching) == true);
REQUIRE(strcmp("foo*.trafficserver.com", matching) == 0);
Expand Down