Skip to content

LSan: Fix memory leak of test_X509HostnameValidator #10161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
masaori335 merged 1 commit into from
Aug 15, 2023
Merged

LSan: Fix memory leak of test_X509HostnameValidator #10161

masaori335 merged 1 commit into from
Aug 15, 2023

Conversation

@masaori335
Copy link
Contributor

@masaori335 masaori335 commented Aug 8, 2023 

===============================================================================
All tests passed (27 assertions in 5 test cases)

     Allocated      |   Allocated Count  |        In-Use      |    In-Use Count    | Type Size  | Chunk Size | HP Fails |   Free List Name
--------------------|--------------------|--------------------|--------------------|------------|------------|----------|----------------------------------
                  0 |                  0 |            | TOTAL
-----------------------------------------------------------------------------------------

=================================================================
==28635==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 352 byte(s) in 1 object(s) allocated from:
    #0 0x10aec84ad in wrap_malloc+0x9d (libclang_rt.asan_osx_dynamic.dylib:x86_64h+0xdf4ad) (BuildId: 7be29bc853af3228b5ae02c6da2408ac2400000010000000000a0a0000000d00)
    #1 0x10a78ec21 in CRYPTO_malloc+0x91 (libcrypto.1.1.dylib:x86_64+0x15cc21) (BuildId: e5b1f7be8de23d9b8660a3bf087a555932000000200000000100000000000d00)
    #2 0x10a78ec62 in CRYPTO_zalloc+0x22 (libcrypto.1.1.dylib:x86_64+0x15cc62) (BuildId: e5b1f7be8de23d9b8660a3bf087a555932000000200000000100000000000d00)
    #3 0x10a661bf6 in asn1_item_embed_new+0x2d6 (libcrypto.1.1.dylib:x86_64+0x2fbf6) (BuildId: e5b1f7be8de23d9b8660a3bf087a555932000000200000000100000000000d00)
    #4 0x10a66190e in ASN1_item_ex_new+0x1e (libcrypto.1.1.dylib:x86_64+0x2f90e) (BuildId: e5b1f7be8de23d9b8660a3bf087a555932000000200000000100000000000d00)
    #5 0x10a65da8c in asn1_item_embed_d2i+0x7ec (libcrypto.1.1.dylib:x86_64+0x2ba8c) (BuildId: e5b1f7be8de23d9b8660a3bf087a555932000000200000000100000000000d00)
    #6 0x10a65d273 in ASN1_item_ex_d2i+0x63 (libcrypto.1.1.dylib:x86_64+0x2b273) (BuildId: e5b1f7be8de23d9b8660a3bf087a555932000000200000000100000000000d00)
    #7 0x10a65d1e4 in ASN1_item_d2i+0x64 (libcrypto.1.1.dylib:x86_64+0x2b1e4) (BuildId: e5b1f7be8de23d9b8660a3bf087a555932000000200000000100000000000d00)
    #8 0x10a8446ab in d2i_X509+0x2b (libcrypto.1.1.dylib:x86_64+0x2126ab) (BuildId: e5b1f7be8de23d9b8660a3bf087a555932000000200000000100000000000d00)
    #9 0x10a7abdda in PEM_ASN1_read_bio+0x8a (libcrypto.1.1.dylib:x86_64+0x179dda) (BuildId: e5b1f7be8de23d9b8660a3bf087a555932000000200000000100000000000d00)
    #10 0x10a7ad82a in PEM_read_bio_X509+0x3a (libcrypto.1.1.dylib:x86_64+0x17b82a) (BuildId: e5b1f7be8de23d9b8660a3bf087a555932000000200000000100000000000d00)
    #11 0x1091221d0 in load_cert_from_string(char const*) test_X509HostnameValidator.cc:101
    #12 0x109077392 in C_A_T_C_H_T_E_S_T_2() test_X509HostnameValidator.cc:117
    #13 0x10903ab12 in Catch::TestInvokerAsFunction::invoke() const catch.hpp:14328
    #14 0x10902344e in Catch::TestCase::invoke() const catch.hpp:14167
    #15 0x10902323e in Catch::RunContext::invokeActiveTestCase() catch.hpp:13027
    #16 0x10901c938 in Catch::RunContext::runCurrentTest(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>&) catch.hpp:13000
    #17 0x10901a707 in Catch::RunContext::runTest(Catch::TestCase const&) catch.hpp:12761
    #18 0x10902af69 in Catch::(anonymous namespace)::TestGroup::execute() catch.hpp:13354
    #19 0x109029a06 in Catch::Session::runInternal() catch.hpp:13560
    #20 0x109029412 in Catch::Session::run() catch.hpp:13516
    #21 0x10907fc0a in main test_X509HostnameValidator.cc:181
    #22 0x7ff80261d41e in start+0x76e (dyld:x86_64+0xfffffffffff6e41e) (BuildId: 5db85b72c63a318291e55c942ec30e4832000000200000000100000000040d00)

@masaori335 masaori335 added the ASan Address Sanitizer label Aug 8, 2023
@masaori335 masaori335 added this to the 10.0.0 milestone Aug 8, 2023
@masaori335 masaori335 self-assigned this Aug 8, 2023
@masaori335
Copy link
Contributor Author

masaori335 commented Aug 9, 2023

[approve ci centos]

@masaori335 masaori335 mentioned this pull request Aug 13, 2023
Closed
7 tasks
@bneradt bneradt requested a review from ywkaras August 14, 2023 22:28
@masaori335 masaori335 merged commit 9ea4a17 into apache:master Aug 15, 2023
cmcfarlen pushed a commit to cmcfarlen/trafficserver that referenced this pull request Jun 3, 2024
@zwoop
Merge remote-tracking branch 'asf/master'
2ab0df2 
* asf/master: (221 commits)
  LSan: Fix leak of test_Metrics (apache#10179)
  LSan: Fix memory leak of test_EventSystem (apache#10178)
  LSan: Fix memory leak of test_X509HostnameValidator (apache#10161)
  Remove cqtx log field (apache#10111)
  Require ATS plugins to be compiled with C++17. (apache#10007)
  Fix conf_remap plugin build on macOS (apache#10177)
  libswoc: Update to 1.5.4 (apache#10155)
  Makes cmake build again, on macOS (apache#10172)
  Check SNI in h3 (apache#10184)
  Remove autoconf headers during CMake configuration (apache#10173)
  test_QUICLossDetector.cc: Add back get_hrtime() (apache#10185)
  ink_ink_get_hrtime -> ink_get_hrtime (apache#10182)
  mgmt: make libconfigmanager a true static library (apache#10181)
  Make sure that the thread local time is updated timely (apache#10163)
  Unrequire remap rules for OCSP (apache#10146)
  cache_range test performance improvement (apache#10170)
  Clean up certifier plugin debug messages. (apache#9975)
  cmake: add check for clock_gettime (apache#10169)
  Remove Http3NoError allocations (apache#10165)
  Fix Throttler initialization. (apache#10154)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ywkaras ywkaras ywkaras approved these changes

Assignees

@masaori335 masaori335

Labels

ASan Address Sanitizer

Projects

None yet

Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@masaori335 @ywkaras