Skip to content

Makes cmake build again, on macOS #10172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zwoop merged 1 commit into from
Aug 14, 2023
Merged

Makes cmake build again, on macOS #10172

zwoop merged 1 commit into from
Aug 14, 2023

Conversation

@zwoop
Copy link
Contributor

@zwoop zwoop commented Aug 11, 2023

No description provided.

@zwoop zwoop added Tests CMake work related to CMakes scripts or issues labels Aug 11, 2023
@zwoop zwoop added this to the 10.0.0 milestone Aug 11, 2023
@zwoop zwoop requested review from JosiahWI and bneradt August 11, 2023 04:35
JosiahWI
JosiahWI approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@JosiahWI JosiahWI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@ywkaras
Copy link
Contributor

ywkaras commented Aug 14, 2023

Where do we order our MCBA baseball caps?

@zwoop zwoop merged commit fdd4cd0 into apache:master Aug 14, 2023
@zwoop zwoop deleted the FixCmakeAgain branch August 14, 2023 22:21
cmcfarlen pushed a commit to cmcfarlen/trafficserver that referenced this pull request Jun 3, 2024
@zwoop
Merge remote-tracking branch 'asf/master'
2ab0df2 
* asf/master: (221 commits)
  LSan: Fix leak of test_Metrics (apache#10179)
  LSan: Fix memory leak of test_EventSystem (apache#10178)
  LSan: Fix memory leak of test_X509HostnameValidator (apache#10161)
  Remove cqtx log field (apache#10111)
  Require ATS plugins to be compiled with C++17. (apache#10007)
  Fix conf_remap plugin build on macOS (apache#10177)
  libswoc: Update to 1.5.4 (apache#10155)
  Makes cmake build again, on macOS (apache#10172)
  Check SNI in h3 (apache#10184)
  Remove autoconf headers during CMake configuration (apache#10173)
  test_QUICLossDetector.cc: Add back get_hrtime() (apache#10185)
  ink_ink_get_hrtime -> ink_get_hrtime (apache#10182)
  mgmt: make libconfigmanager a true static library (apache#10181)
  Make sure that the thread local time is updated timely (apache#10163)
  Unrequire remap rules for OCSP (apache#10146)
  cache_range test performance improvement (apache#10170)
  Clean up certifier plugin debug messages. (apache#9975)
  cmake: add check for clock_gettime (apache#10169)
  Remove Http3NoError allocations (apache#10165)
  Fix Throttler initialization. (apache#10154)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bneradt bneradt bneradt approved these changes

@JosiahWI JosiahWI JosiahWI approved these changes

Assignees

@zwoop zwoop

Labels

CMake work related to CMakes scripts or issues Tests

Projects

None yet

Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@zwoop @ywkaras @bneradt @JosiahWI