Require ATS plugins to be compiled with C++17 #10007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywkaras
force-pushed
the
tsapi_obs
branch
2 times, most recently
from
fcd2c77 to
1b6095a
Compare
ywkaras
force-pushed
the
tsapi_obs
branch
13 times, most recently
from
5ea11bf to
2a1c65d
Compare
ywkaras
force-pushed
the
tsapi_obs
branch
5 times, most recently
from
35bf59e to
022952b
Compare
| time(&t); | ||
| e = (NULL == expire ? 0 : strtol(expire, NULL, 16)); | ||
| i = TSREMAP_DID_REMAP; | ||
| e = (NULL == expire ? 0 : strtol(expire, NULL, 16)); |
Contributor
Author
There was a problem hiding this comment.
OK I addressed all of these I think in a new (big) commit.
include/ts/apidefs.h.in
Outdated
| @@ -147,959 +157,1360 @@ extern "C" { | |||
| #endif | |||
|
|
|||
| #ifndef TS_DEPRECATED | |||
| #define TS_DEPRECATED __attribute__((deprecated)) | |||
| #define TS_DEPRECATED [[deprecated]] | |||
Member
There was a problem hiding this comment.
We should probably remove this and do the substitution. This was done initially because of OS dependencies, but now it's part of C++.
|
|
||
| */ | ||
| #define TS_NULL_MLOC ((TSMLoc)0) | ||
| extern "C" void TSPluginInit(int argc, const char *argv[]); |
Member
There was a problem hiding this comment.
Might make a comment that this is "C" because it's looked up by name and not implicitly.
Contributor
Author
There was a problem hiding this comment.
See above line 1518.
Renames all plugin and example files with .c extension to have .cc extensions, Fix resulting errors. Minimize use of preprocessor. Change typedefs to 'using'. Updates to documentation. Put current TS API declarations in tsapi::c namespace. Limit impact to current code with 'using namespace tsapi::c'. Remove TS_DEPRECATED in apidefs.h.
Contributor
Author
|
I recommend reviewing this with whitespace-only changes hidden. I introduced a nested namespace around existing declarations, and clang format insists on indenting the declarations. |
cmcfarlen
approved these changes
Aug 15, 2023
8 tasks
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Jun 3, 2024
* asf/master: (221 commits) LSan: Fix leak of test_Metrics (apache#10179) LSan: Fix memory leak of test_EventSystem (apache#10178) LSan: Fix memory leak of test_X509HostnameValidator (apache#10161) Remove cqtx log field (apache#10111) Require ATS plugins to be compiled with C++17. (apache#10007) Fix conf_remap plugin build on macOS (apache#10177) libswoc: Update to 1.5.4 (apache#10155) Makes cmake build again, on macOS (apache#10172) Check SNI in h3 (apache#10184) Remove autoconf headers during CMake configuration (apache#10173) test_QUICLossDetector.cc: Add back get_hrtime() (apache#10185) ink_ink_get_hrtime -> ink_get_hrtime (apache#10182) mgmt: make libconfigmanager a true static library (apache#10181) Make sure that the thread local time is updated timely (apache#10163) Unrequire remap rules for OCSP (apache#10146) cache_range test performance improvement (apache#10170) Clean up certifier plugin debug messages. (apache#9975) cmake: add check for clock_gettime (apache#10169) Remove Http3NoError allocations (apache#10165) Fix Throttler initialization. (apache#10154) ...
bryancall
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames all plugin and example files with .c extension to have .cc extensions. Fix resulting errors.