Unrequire remap rules for OCSP #10146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maskit
force-pushed
the
ocsp_unrequire_remap
branch
from
934c75f to
861694a
Compare
The change to use FetchSM for OCSP requests unintentionally made ATS rely on remap rules, and that effectively broke OCSP if a user sets remap_required to 1. To recover the original behavior which does not rely on remap rules, this introduces a new flag for FetchSM, TS_FETCH_FLAGS_SKIP_REMAP, and the flag enables skipping remap on a transaction initiated by FetchSM even if remap_required is set to 1. Since the flag is part of TS API, this also enables plugins to make HTTP requests for other servers without remap rules.
maskit
force-pushed
the
ocsp_unrequire_remap
branch
from
861694a to
cd77560
Compare
Contributor
|
I think I understand now (Thanks to @maskit ). The issue is that when setting up the FetchSM, there's no way to signal the HttpSM that it shouldn't require remap. The existing configurations and APIs works on the transactions, which you don't have yet when setting up the FetchSM (obviously). |
bneradt
approved these changes
Aug 8, 2023
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Jun 3, 2024
* asf/master: (221 commits) LSan: Fix leak of test_Metrics (apache#10179) LSan: Fix memory leak of test_EventSystem (apache#10178) LSan: Fix memory leak of test_X509HostnameValidator (apache#10161) Remove cqtx log field (apache#10111) Require ATS plugins to be compiled with C++17. (apache#10007) Fix conf_remap plugin build on macOS (apache#10177) libswoc: Update to 1.5.4 (apache#10155) Makes cmake build again, on macOS (apache#10172) Check SNI in h3 (apache#10184) Remove autoconf headers during CMake configuration (apache#10173) test_QUICLossDetector.cc: Add back get_hrtime() (apache#10185) ink_ink_get_hrtime -> ink_get_hrtime (apache#10182) mgmt: make libconfigmanager a true static library (apache#10181) Make sure that the thread local time is updated timely (apache#10163) Unrequire remap rules for OCSP (apache#10146) cache_range test performance improvement (apache#10170) Clean up certifier plugin debug messages. (apache#9975) cmake: add check for clock_gettime (apache#10169) Remove Http3NoError allocations (apache#10165) Fix Throttler initialization. (apache#10154) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change to use FetchSM for OCSP requests (#9591) unintentionally made ATS rely on remap rules, and that effectively broke OCSP if a user sets
remap_requiredto 1. To recover the original behavior which does not rely on remap rules, this introduces a new flag for FetchSM,TS_FETCH_FLAGS_SKIP_REMAP, and the flag enables skipping remap on a transaction initiated byFetchSMeven ifremap_requiredis set to 1.Since the flag is part of TS API, this also enables plugins to make HTTP requests for other servers without remap rules (if FetchSM is used).