CMake: Fix binaryDir of presets #10665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Is it still helpful to have the |
Contributor
Author
|
I'm fine with |
masaori335
force-pushed
the
cmake-binary-dir
branch
from
3ebdfe5 to
3598d14
Compare
JosiahWI
approved these changes
Oct 28, 2023
Contributor
JosiahWI
left a comment
JosiahWI
left a comment
There was a problem hiding this comment.
Looks consistent now. Thanks for the improvement!
cmcfarlen
reviewed
Oct 30, 2023
masaori335
force-pushed
the
cmake-binary-dir
branch
from
3598d14 to
0246682
Compare
JosiahWI
approved these changes
Oct 31, 2023
Contributor
|
[approve ci clang-format] |
bneradt
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consistency with other presets and
.gitignore.trafficserver/CMakePresets.json
Line 36 in 78506e0
trafficserver/CMakePresets.json
Line 70 in 78506e0
trafficserver/.gitignore
Line 209 in 78506e0
Update: now the prefix is
build-as @JosiahWI suggested.