Skip to content

CMake: Fix binaryDir of presets #10665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bneradt merged 1 commit into from
Nov 9, 2023
Merged

CMake: Fix binaryDir of presets #10665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ m4/ltversion.m4
m4/lt~obsolete.m4

# common directory name for out-of-tree CMake builds
build
build*

Makefile
Makefile-pl
Expand Down
4 changes: 2 additions & 2 deletions CMakePresets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"displayName": "development",
"description": "Development Presets",
"inherits": ["default"],
"binaryDir": "${sourceDir}/cmake-build-${presetName}",
"binaryDir": "${sourceDir}/build-${presetName}",
"generator": "Ninja",
"cacheVariables": {
"CMAKE_EXPORT_COMPILE_COMMANDS": "ON",
Expand Down Expand Up @@ -67,7 +67,7 @@
"displayName": "CI defaults",
"description": "Defaults for CI Pipeline builds",
"generator": "Ninja",
"binaryDir": "${sourceDir}/cmake-ci",
"binaryDir": "${sourceDir}/build-ci",
"cacheVariables": {
"CMAKE_BUILD_TYPE": "Debug",
"CMAKE_COMPILE_WARNING_AS_ERROR": "ON",
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ Here is an example user preset:
"name": "mydev",
"displayName": "my development",
"description": "My Development Presets",
"binaryDir": "${sourceDir}/cmake-build-dev-clang",
"binaryDir": "${sourceDir}/build-dev-clang",
"inherits": ["clang", "dev"],
"cacheVariables": {
"CMAKE_INSTALL_PREFIX": "/opt/ats-cmake",
Expand Down