Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stripe metrics in the exclusive span case #11023

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Fix stripe metrics in the exclusive span case #11023

merged 1 commit into from
Feb 1, 2024

Conversation

masaori335
Copy link
Contributor

Fix #11022.

@masaori335 masaori335 added this to the 10.0.0 milestone Jan 30, 2024
@masaori335 masaori335 self-assigned this Jan 30, 2024
@masaori335 masaori335 force-pushed the autest-exclusive-span branch from 59b8fd8 to 143ba2e Compare January 30, 2024 07:07
brbzull0
brbzull0 approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@brbzull0 brbzull0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Thanks.

@masaori335 masaori335 merged commit 597e2e8 into apache:master Feb 1, 2024
15 checks passed
phongn pushed a commit to phongn/trafficserver that referenced this pull request Feb 1, 2024
@masaori335 @phongn
Fix stripe metrics in the exclusive span case (apache#11023)
59b8e33
@zwoop
Copy link
Contributor

zwoop commented Feb 6, 2024

@masaori335 This has merge conflict with 9.2.x, can you make a 9.2.x PR please ? Or let me know what other PRs needs to be picked as well ?

@masaori335
Copy link
Contributor Author

I just noticed we don't need to backport this because the #9263, added the stripe metrics, wasn't backported to the 9.2.x branch. I'll remove this from the 9.2.x project.

masaori335 added a commit to masaori335/trafficserver that referenced this pull request Dec 10, 2024
@masaori335
Fix stripe metrics in the exclusive span case (apache#11023)
530d711 
(cherry picked from commit 597e2e8)

Conflicts:
        src/iocore/cache/Cache.cc
        tests/gold_tests/cache/gold/storage_metrics_2_stdout.gold
        tests/gold_tests/cache/storage-metrics.test.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brbzull0 brbzull0 brbzull0 approved these changes

Assignees

@masaori335 masaori335

Labels
Cache Metrics
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.

proxy.process.cache.stripes counts exclusive span twice
3 participants
@masaori335 @zwoop @brbzull0