Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This adds a simple (static) metric for counting cache stripes #9263

Merged
merged 1 commit into from
Jan 17, 2023
Merged

This adds a simple (static) metric for counting cache stripes #9263

merged 1 commit into from
Jan 17, 2023

Conversation

zwoop
Copy link
Contributor

@zwoop zwoop commented Dec 20, 2022 •
edited
Loading

With this patch, we get metrics like

proxy.process.cache.stripes 4
proxy.process.cache.volume_0.stripes 2
proxy.process.cache.volume_1.stripes 2

@zwoop zwoop added this to the 10.0.0 milestone Dec 20, 2022
@zwoop zwoop self-assigned this Dec 20, 2022
@zwoop zwoop requested review from cmcfarlen and ezelkow1 December 20, 2022 02:36
cmcfarlen
cmcfarlen previously approved these changes Dec 20, 2022
View reviewed changes
@ezelkow1
Copy link
Member

[approve ci]

@SolidWallOfCode
Copy link
Member

Would it not be simpler to copy the value for gnvol instead of independently computing the value? I'm not happy with "spans", either, since those are called "stripes" in the documentation.

@bryancall
Copy link
Contributor

@zwoop Can you please address @SolidWallOfCode comment.

@bryancall bryancall requested a review from bneradt January 10, 2023 00:30
bneradt
bneradt previously approved these changes Jan 10, 2023
View reviewed changes
@zwoop
This adds a simple (static) metric for counting cache stripes
13bb246 
With this patch, we get metrics like

proxy.process.cache.stripes 4
proxy.process.cache.volume_0.stripes 2
proxy.process.cache.volume_1.stripes 2
@zwoop zwoop dismissed stale reviews from bneradt and cmcfarlen via 13bb246 January 13, 2023 17:36
@zwoop zwoop changed the title This adds a simple (static) metric for counting cache spans This adds a simple (static) metric for counting cache stripes Jan 13, 2023
@zwoop
Copy link
Contributor Author

zwoop commented Jan 13, 2023

Would it not be simpler to copy the value for gnvol instead of independently computing the value? I'm not happy with "spans", either, since those are called "stripes" in the documentation.

I changed all "spans" to "stripes".

@zwoop
Copy link
Contributor Author

zwoop commented Jan 17, 2023

[approve ci autest 2]

@zwoop zwoop merged commit ff7065f into apache:master Jan 17, 2023
@zwoop zwoop deleted the SpanVolMetrics branch January 17, 2023 22:51
@masaori335 masaori335 mentioned this pull request Feb 7, 2024
Merged
@maskit maskit mentioned this pull request Aug 15, 2024
Open
91 tasks
@cmcfarlen cmcfarlen mentioned this pull request Aug 15, 2024
Merged
masaori335 pushed a commit to masaori335/trafficserver that referenced this pull request Dec 10, 2024
@zwoop @masaori335
This adds a simple (static) metric for counting cache stripes (apache…
7f08a8a 
…#9263)

With this patch, we get metrics like

proxy.process.cache.stripes 4
proxy.process.cache.volume_0.stripes 2
proxy.process.cache.volume_1.stripes 2

(cherry picked from commit ff7065f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bneradt bneradt bneradt approved these changes

@cmcfarlen cmcfarlen cmcfarlen left review comments

@ezelkow1 ezelkow1 Awaiting requested review from ezelkow1

Assignees

@zwoop zwoop

Labels
Cache Metrics New Feature Release Doc Done
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@zwoop @ezelkow1 @SolidWallOfCode @bryancall @cmcfarlen @bneradt