Fail earlier if Netcat is not installed #11438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some AuTests require Netcat as a client, but do not get skipped if it is missing. This updates the tests so that they get skipped if Netcat is not installed.
bneradt
reviewed
Jun 10, 2024
Contributor
bneradt
left a comment
bneradt
left a comment
There was a problem hiding this comment.
Looks good to me. I double-checked that each of these does indeed use nc or calls a script that does.
As usual, I'll let a non-Yahoo reviewer approve.
Contributor
Author
|
We may not want to merge this because it would cause CI to pass without indicating an issue if the |
JosiahWI
changed the title
Contributor
Author
|
I've repurposed the PR to have the CMake build and autest.sh check for netcat and fail if it is missing, rather than skipping tests based on its presence. |
bneradt
reviewed
Jun 20, 2024
Contributor
bneradt
left a comment
bneradt
left a comment
There was a problem hiding this comment.
Looks good. Thanks for giving this nc requirement explicit messaging.
cmcfarlen
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some AuTests require Netcat as a client, but do not get skipped if it is missing.
This updates the tests so that they get skipped if Netcat is not installed.EDIT: This updates CMakeLists.txt and autest.sh to fail appropriately if Netcat is missing.