Skip to content

Fail earlier if Netcat is not installed #11438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JosiahWI merged 4 commits into from
Jun 20, 2024
Merged

Fail earlier if Netcat is not installed #11438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3c31159
Skip appropriate AuTests if Netcat is not present
JosiahWI Jun 10, 2024
4ca4d40
Revert "Skip appropriate AuTests if Netcat is not present"
JosiahWI Jun 20, 2024
6cd6aae
Require nc with ENABLE_AUTEST in CMake build
JosiahWI Jun 20, 2024
e6a062a
Fail autest.sh if nc is not present
JosiahWI Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,6 +515,7 @@ find_package(resolv)
if(ENABLE_DOCS OR ENABLE_AUTEST)
find_package(Python3 REQUIRED)
find_program(PipEnv pipenv REQUIRED)
find_program(NETCAT_PROGRAM nc REQUIRED)
endif()

if(ENABLE_DOCS)
Expand Down
1 change: 1 addition & 0 deletions tests/autest.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ cd "$SCRIPT_DIR"
./prepare_proxy_verifier.sh || fail "Failed to install Proxy Verifier."
export PYTHONPATH=$(pwd):$PYTHONPATH
./test-env-check.sh || fail "Failed Python environment checks."
hash nc 2>/dev/null || fail "Netcat is not installed."
# this is for rhel or centos systems
echo "Environment config finished. Running AuTest..."
exec pipenv run env \
Expand Down