Clarify VCONN_CLOSE serialization in developer docs #11459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosiahWI
force-pushed
the
feat/better-vconn-close-docs
branch
from
fe4ec13 to
45d117f
Compare
ezelkow1
approved these changes
Jun 24, 2024
JosiahWI
added a commit
to JosiahWI/trafficserver
that referenced
this pull request
Jul 8, 2024
…pache#967) Plugins may want to use both TLS and HTTP hooks without a mutex. An example of this is the ja3_fingerprint, which has a possible race condition between the VCONN_CLOSE hook and HTTP hooks according to the current documentation. However, these events happen on the same thread and are thus serialized. This updates the documentation to clarify that the current behavior is guaranteed. Co-authored-by: JosiahWI <41302989+JosiahWI@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plugins may want to use both TLS and HTTP hooks without a mutex. An example of this is the ja3_fingerprint, which has a possible race condition between the
VCONN_CLOSEhook and HTTP hooks according to the current documentation. However, these events happen on the same thread and are thus serialized. This updates the documentation to clarify that the current behavior is guaranteed.