TS-4555: Make CPP API use a reserved transaction arg. #967
Conversation
|
Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/602/ for details. |
|
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/707/ for details. |
| setupTransactionManagement() | ||
| { | ||
| // Reserve a transaction slot | ||
| TSAssert(TS_SUCCESS == TSHttpArgIndexReserve("atscppapi", "ATS CPP API", &TRANSACTION_STORAGE_INDEX)); |
There was a problem hiding this comment.
Don't you want to check with TSHttpArgIndexNameLookup first?
There was a problem hiding this comment.
Hmm, OK I guess this is safe because of the pthread_once in utils::internal::initTransactionManagement(). It seems a little fragile to me though. I think it would be more obvious if this was just done in GlobalPlugin::GlobalPlugin() and the intermediate functions were removed.
There was a problem hiding this comment.
I think the problem with GlobalPlugin::GlobalPlugin is it can be called multiple times, once for each global plugin defined. I think only one transaction arg is required, though, for all global plugins.
There was a problem hiding this comment.
Right, you would use TSHttpArgIndexNameLookup.
…pache#967) Plugins may want to use both TLS and HTTP hooks without a mutex. An example of this is the ja3_fingerprint, which has a possible race condition between the VCONN_CLOSE hook and HTTP hooks according to the current documentation. However, these events happen on the same thread and are thus serialized. This updates the documentation to clarify that the current behavior is guaranteed. Co-authored-by: JosiahWI <41302989+JosiahWI@users.noreply.github.com>
3 participants
No description provided.