Remove matrix parameters from the cookie remap plugin #11579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
bryancall
force-pushed
the
cookie_remap_params
branch
from
10a6062 to
bf0afb4
Compare
bryancall
changed the title
Member
|
[approve ci] |
maskit
approved these changes
Jul 22, 2024
maskit
requested changes
Jul 22, 2024
Member
maskit
left a comment
maskit
left a comment
There was a problem hiding this comment.
$ git grep "matrix param" tests/
tests/gold_tests/pluginTest/cookie_remap/matrixparams.test.py:Test.testName = "cookie_remap: Tests when matrix parameters are present"
tests/gold_tests/pluginTest/cookie_remap/matrixparams.test.py: inserting matrix parameters in remap")
tests/gold_tests/pluginTest/cookie_remap/matrixparams.test.py:tr = Test.AddTestRun("inserting matrix params in remap and \
maskit
approved these changes
Jul 26, 2024
Contributor
|
Cherry-picked to v10.0.x |
cmcfarlen
pushed a commit
that referenced
this pull request
Jul 30, 2024
(cherry picked from commit 319190f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.