Skip to content

Remove matrix parameters from the cookie remap plugin #11579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bryancall merged 2 commits into from
Jul 29, 2024
Merged

Remove matrix parameters from the cookie remap plugin #11579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf0afb4
Remove matrix parameters from the cookie remap plugin
bryancall Jul 18, 2024
d07bfc2
Remove matrix parameter tests for cookie remap plugin
bryancall Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions plugins/experimental/cookie_remap/cookie_remap.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,6 @@ class UrlComponents
// we will just
// append them to the path
_d[pre_remap].path_str = _get_url_comp(urlh, TSUrlPathGet);
auto matrix = _get_url_comp(urlh, TSUrlHttpParamsGet);
if (!matrix.empty()) {
_d[pre_remap].path_str.append(";", 1).append(matrix);
}
}
return _d[pre_remap].path_str;
}
Expand Down
24 changes: 0 additions & 24 deletions tests/gold_tests/pluginTest/cookie_remap/configs/matrixconfig.txt
View file
Open in desktop

This file was deleted.

11 changes: 0 additions & 11 deletions tests/gold_tests/pluginTest/cookie_remap/gold/matrix.gold
View file
Open in desktop

This file was deleted.

186 changes: 0 additions & 186 deletions tests/gold_tests/pluginTest/cookie_remap/matrixparams.test.py
View file
Open in desktop

This file was deleted.