header_rewrite: Allow Txn reenable to be deferred. #11658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmine-nahrain
requested changes
Aug 9, 2024
plugins/header_rewrite/operator.h
Outdated
|
|
||
| void | ||
| // Returns number of executed operators that need to defer call to TSHttpTxnReenable(). It is a fatal error if this | ||
| // returns more than 1. |
Collaborator
There was a problem hiding this comment.
Maybe add a comment specifying that if another rule gets created that needs to be deferred, issue #11549 should be revisited.
The SetBodyFrom operator needs to defer calling Txn reenable until the fetch of the URL providing the response body completes.
ywkaras
force-pushed
the
header_rewrite_defer_reenable
branch
from
d5aeb62 to
ed102cd
Compare
jasmine-nahrain
approved these changes
Aug 13, 2024
masaori335
approved these changes
Aug 13, 2024
masaori335
pushed a commit
to masaori335/trafficserver
that referenced
this pull request
Dec 10, 2024
* Revert "Update set-custom-body response body to exclude headers (apache#780)" This reverts commit cb552b6. * Revert "Add set-body-custom to header_rewrite options" This reverts commit 5bd9999. * Add set-custom-body config item to header_rewrite (apache#11472) * Add set-body-custom to header_rewrite options (cherry picked from commit 5bd9999) (cherry picked from commit 08c614ef0089b175a5b6cee205b748416efb87cd) * Update set-custom-body response body to exclude headers (apache#780) * Update response body to exclude headers * Update tests to check both response with headers and response body only * Update header_rewrite_custom_body.test.py * Fix tests to check headers and body (cherry picked from commit cb552b6) (cherry picked from commit e12f4798d0d46bd90c810f8f3a7a067ea3b2c76f) * Remove debug check due to known issue (cherry picked from commit 964b12cc21a9a7c3f9d3fd50286e4cd2d2757bcc) * Fix formatting Remove whitespaces doc formatting fix Doc formatting fix * Rename to set-body-from * Add test for failed second call * Add more test cases * Clarify test cases * Update tests * Update header_rewrite.en.rst * Fix flakey test --------- Co-authored-by: Jasmine Emanouel <jemanouel@apple.com> (cherry picked from commit 0d8a6ac) * header_rewrite: Allow Txn reenable to be deferred. (apache#11658) The SetBodyFrom operator needs to defer calling Txn reenable until the fetch of the URL providing the response body completes. (cherry picked from commit 50f5f23) * cherry-pick cleanup * cherry-pick cleanup * Cleanup of header_rewrite redirect operator when invoked globally. (apache#11551) Also includes new Au test coverage. (cherry picked from commit 94dfd0e) * fix return value --------- Co-authored-by: Jasmine Emanouel <40879549+jasmine-nahrain@users.noreply.github.com> Co-authored-by: Walt Karas <wkaras@yahooinc.com>
masaori335
pushed a commit
to masaori335/trafficserver
that referenced
this pull request
May 29, 2025
* Add set-custom-body config item to header_rewrite (apache#11472) * Add set-body-custom to header_rewrite options (cherry picked from commit 5bd9999) (cherry picked from commit 08c614ef0089b175a5b6cee205b748416efb87cd) * Update set-custom-body response body to exclude headers (apache#780) * Update response body to exclude headers * Update tests to check both response with headers and response body only * Update header_rewrite_custom_body.test.py * Fix tests to check headers and body (cherry picked from commit cb552b6) (cherry picked from commit e12f4798d0d46bd90c810f8f3a7a067ea3b2c76f) * Remove debug check due to known issue (cherry picked from commit 964b12cc21a9a7c3f9d3fd50286e4cd2d2757bcc) * Fix formatting Remove whitespaces doc formatting fix Doc formatting fix * Rename to set-body-from * Add test for failed second call * Add more test cases * Clarify test cases * Update tests * Update header_rewrite.en.rst * Fix flakey test --------- Co-authored-by: Jasmine Emanouel <jemanouel@apple.com> (cherry picked from commit 0d8a6ac) * Cleanup of header_rewrite redirect operator when invoked globally. (apache#11551) Also includes new Au test coverage. (cherry picked from commit 94dfd0e) * header_rewrite: Allow Txn reenable to be deferred. (apache#11658) The SetBodyFrom operator needs to defer calling Txn reenable until the fetch of the URL providing the response body completes. (cherry picked from commit 50f5f23) --------- Co-authored-by: Jasmine Emanouel <40879549+jasmine-nahrain@users.noreply.github.com> Co-authored-by: Walt Karas <wkaras@yahooinc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SetBodyFrom operator needs to defer calling Txn reenable until the fetch of the URL providing the response body completes.