TS-4652 Fixes log field initialization, previously crippled #813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@bryancall Please review. |
|
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/452/ for details. |
|
Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/347/ for details. |
proxy/logging/Log.cc
Outdated
| if (config_flags & STANDALONE_COLLATOR) { | ||
| config->collation_mode = Log::COLLATION_HOST; | ||
| } | ||
| init_fields(); |
Contributor
There was a problem hiding this comment.
Both sided of this branch now call init_fields(). Do you want to hoist the call up and simplify?
Contributor
Author
|
Let me take a look, but I was going for the simplest solution that works, with minimal risk. It's pretty finicky on the order :) |
Contributor
Author
|
Ah, yeah, I'm pretty sure that entire if() can be safely eliminated (famous last words ...). |
Contributor
Author
|
@jpeach @bryancall check the update please. |
|
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/456/ for details. |
|
Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/351/ for details. |
Contributor
|
👍 |
Contributor
|
👍 - Tested and it is working |
JosiahWI
pushed a commit
to JosiahWI/trafficserver
that referenced
this pull request
Jul 19, 2023
Connection error should be stream error according to https://datatracker.ietf.org/doc/html/rfc7540#section-8.1.2.6 Do not sent EOS or WRITE_COMPLETE to tunnel handlers which are not setup for them in outbound mode In some cases when shutting down after a self initiated GOAWAY, we will (again) sent WRITE_COMPLETE or EOS to HttpSM::tunnel_handler. I suspect it is still possible to send the WRITE_COMPLETE or EOS in some edge cases as the stream state does not reflect one to one to a tunnel handler and will try to setup tests for this. Fix assertion crash on cause_of_death_errno in case of parse response headers error Set end stream on request headers if method post etc & explicit length 0 Some origins RST on request headers with explicit zero length and no end stream flag, causing the request to fail. We emulate chromium behaviour here with this change to prevent this Conflicts: proxy/http2/Http2Stream.cc Co-authored-by: Kees Spoelstra <kd.spoelstra@gmail.com>
masaori335
pushed a commit
to masaori335/trafficserver
that referenced
this pull request
Dec 10, 2024
* Revert "Update set-custom-body response body to exclude headers (apache#780)" This reverts commit cb552b6. * Revert "Add set-body-custom to header_rewrite options" This reverts commit 5bd9999. * Add set-custom-body config item to header_rewrite (apache#11472) * Add set-body-custom to header_rewrite options (cherry picked from commit 5bd9999) (cherry picked from commit 08c614ef0089b175a5b6cee205b748416efb87cd) * Update set-custom-body response body to exclude headers (apache#780) * Update response body to exclude headers * Update tests to check both response with headers and response body only * Update header_rewrite_custom_body.test.py * Fix tests to check headers and body (cherry picked from commit cb552b6) (cherry picked from commit e12f4798d0d46bd90c810f8f3a7a067ea3b2c76f) * Remove debug check due to known issue (cherry picked from commit 964b12cc21a9a7c3f9d3fd50286e4cd2d2757bcc) * Fix formatting Remove whitespaces doc formatting fix Doc formatting fix * Rename to set-body-from * Add test for failed second call * Add more test cases * Clarify test cases * Update tests * Update header_rewrite.en.rst * Fix flakey test --------- Co-authored-by: Jasmine Emanouel <jemanouel@apple.com> (cherry picked from commit 0d8a6ac) * header_rewrite: Allow Txn reenable to be deferred. (apache#11658) The SetBodyFrom operator needs to defer calling Txn reenable until the fetch of the URL providing the response body completes. (cherry picked from commit 50f5f23) * cherry-pick cleanup * cherry-pick cleanup * Cleanup of header_rewrite redirect operator when invoked globally. (apache#11551) Also includes new Au test coverage. (cherry picked from commit 94dfd0e) * fix return value --------- Co-authored-by: Jasmine Emanouel <40879549+jasmine-nahrain@users.noreply.github.com> Co-authored-by: Walt Karas <wkaras@yahooinc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.