Skip to content

Conversation

@masaori335
Copy link
Contributor

@masaori335 masaori335 commented Jan 20, 2025

Prior to the change, the range-request config controls compress plugin to skip compression if Range request. However, this makes unexpected behavior once the object is cached without Range request.

To fix the case, this removes Range header if client send both of Accept-Encoding and Range header.

Update: add new options to choose Accept-Encoding header or Range header if a client sends both headers.

  • ignore-range (or true) : Remove Range header
  • no-compression: Remove Accept-Encoding header
  • none (or false): do nothing

@masaori335 masaori335 added the compress compress plugin label Jan 20, 2025
@masaori335 masaori335 added this to the 10.1.0 milestone Jan 20, 2025
@masaori335 masaori335 self-assigned this Jan 20, 2025
@masaori335 masaori335 force-pushed the asf-master-compress-range branch from d24802a to 99b4ac6 Compare January 20, 2025 07:55
@bneradt bneradt requested a review from bryancall January 27, 2025 23:09
@masaori335 masaori335 force-pushed the asf-master-compress-range branch from 60b6002 to c911c9b Compare February 20, 2025 05:51
@masaori335 masaori335 changed the title [compress] Fix range-request false [compress] Add range request control option Feb 20, 2025
@masaori335 masaori335 force-pushed the asf-master-compress-range branch from abe61ed to c3859ed Compare February 20, 2025 06:41
@masaori335 masaori335 removed this from ATS v10.0.x Feb 25, 2025
@masaori335 masaori335 merged commit fd23191 into apache:master Mar 4, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants