[compress] Add an option to do not compress partial object #12121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masaori335
commented
Mar 24, 2025
| } | ||
|
|
||
| // check Partial Object is transformable | ||
| if (host_configuration->range_request_ctl() == RangeRequestCtrl::NO_COMPRESSION) { |
Contributor
Author
There was a problem hiding this comment.
This block restores code prior to the PR #11975 and add another check of Content-Range header in server response. Because cache_range_request might remove Range header from client request.
https://github.com/apache/trafficserver/pull/11975/files#diff-a50782f349c34e95c6c8643b834aaeba685f244f78a645e85a402bbda9012fb6L680-L689
bryancall
requested changes
Apr 4, 2025
masaori335
force-pushed
the
slice-compress
branch
from
4b6e504 to
86bb2aa
Compare
Contributor
Author
|
Rebased on the latest master. |
bryancall
approved these changes
May 12, 2025
masaori335
added a commit
to masaori335/trafficserver
that referenced
this pull request
May 27, 2025
) (cherry picked from commit 678d786)
This was referenced May 27, 2025
cmcfarlen
pushed a commit
that referenced
this pull request
Jun 3, 2025
…12258) * Couple of coverity fixes. (#12145) * Fix for CID-1593545: Uninitialized scalar field * Fix for 1593544 : Unchecked return value from library (cherry picked from commit d605c6c) * [compress] Add an option to do not compress partial object (#12121) (cherry picked from commit 678d786) --------- Co-authored-by: Damian Meden <dmeden@apache.org>
Contributor
|
This was added to milestone 10.1.x via #12258 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During #11975 test, we found that new configs doesn't work as expected if other plugins (like
cache_range_request) run first and removeRangeheader from client request.Also, @vmamidi wants to send both of
RangeandAccept-Encodingheaders to allow origin server to return "partial content of compressed content".This PR clarify name of current options and add a new option to do not compress partial object.