Skip to content

[TS-3235] fix crash problem caused by sync problem in PluginVC. #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hopkings2008 wants to merge 1 commit into from
Closed

[TS-3235] fix crash problem caused by sync problem in PluginVC. #164

hopkings2008 wants to merge 1 commit into from

Conversation

@hopkings2008
Copy link

@hopkings2008 hopkings2008 commented Jan 21, 2015

This fix is for the multi-thread sync problem exists in PluginVC of TS-3235.
Below is the scenario of this problem:

  1. customer uses interceptplugin which calls TSVIOReenable and TSVConnClose and that will call PluginVC's APIs in their work threads
  2. That customer creates their work threads by using TSThreadCreate which are not controlled by ATS.
  3. Because the interceptplugin works in their work threads and the lock provided by interceptplugin can only sync their work threads and it cannot sync the threads between ATS and interceptplugin, the sync problem will occur when TSVIOReenable and TSVConnClose are called from intercetplugin in customer's work threads.

So, we need to consider this kind of scenario also, as it is common to customer to start their threads.

@bryancall
Copy link
Contributor

bryancall commented Jun 17, 2015

Jira ticket open for this:
https://issues.apache.org/jira/browse/TS-3235

SolidWallOfCode added a commit to SolidWallOfCode/trafficserver that referenced this pull request Dec 9, 2015
@SolidWallOfCode
TS-3235: Additional cleanup and fixes.
dca3387 
This close apache#164.
SolidWallOfCode added a commit to SolidWallOfCode/trafficserver that referenced this pull request Dec 15, 2015
@SolidWallOfCode
TS-3235: Additional cleanup and fixes.
da34d64 
This close apache#164.
SolidWallOfCode pushed a commit to SolidWallOfCode/trafficserver that referenced this pull request Dec 23, 2015
@SolidWallOfCode
TS-3235: fix crash problem caused by sync problem in PluginVC.
ffe0c19 
This closes apache#164.
@asfgit asfgit closed this in c804ebc Dec 29, 2015
SolidWallOfCode pushed a commit to SolidWallOfCode/trafficserver that referenced this pull request May 7, 2016
Merge pull request apache#164 from skawano/TS-3973-5.3.x
03ec0b5 
[TS-3973] convert the rww delay timer to correct units
maskit pushed a commit to maskit/trafficserver that referenced this pull request Feb 2, 2017
Merge branch 'asf/master'
156af63 
* asf/master:
  Doc: Typo "inorder" -> "in order"
  TS-4097: clang-format
  This closes apache#403.
  TS-4109: fix ts.debug/ts.error problem with long string
  TS-4096: update documentation
  TS-4096: ts.now() should return subsecond info for ts_lua plugin
  This closes apache#399.
  doc: fix a typo in traffic_via command reference
  TS-4105: RecDumpRecords passes the wrong record type to its callback
  TS-4097: Encode empty string properly with HPACK
  Format: Clang formatting.
  TS-3235: fix crash problem caused by sync problem in PluginVC. This closes apache#164.
  TS-4094: Clean up RD data in RequestData. This close apache#396.
  TS-4070: RemapProcessor Forward Mapping w/ Recv Port failing w/ TS-2157 changes. This closes apache#375.
  TS-4009: take continuation mutexes in stale_while_revalidate
  Bump the version to v6.2.0, we branched for 6.1.0
  TS-4101: remove unused proxy.config.stats.config_file
  Generic: Remove excess semi-colons and commented out members. This close apache#388.
  TS-4083: CID 1343347: Fix unchecked return value. This closes apache#392
@oknet oknet mentioned this pull request Apr 15, 2017
Closed
SolidWallOfCode pushed a commit to SolidWallOfCode/trafficserver that referenced this pull request Mar 25, 2020
@shinrich
Merge pull request apache#164 from shinrich/ytsats-3075-revert
3abff99 
Revert "YTSATS-3075: Avoid loading unnecessary secondary libraries"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hopkings2008 @bryancall