TS-4070 RemapProcessor Forward Mapping w/ Recv Port failing w/ TS-2157 #375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cschombu
changed the title
proxy/http/remap/RemapProcessor.cc
Outdated
Contributor
There was a problem hiding this comment.
Could you also update the debug message to use the same port you changed it to?
Contributor
There was a problem hiding this comment.
Could you also update the debug message to match the port update?
…7 changes During the rework of RemapProcessor.cc, RemapProcessor::setup_for_remap() as part of the TS-2157 changeset, the port access API appears to have been incorrectly modified to use the client_info.src_addr.host_order_port() API [source port, host order] instead of the client_info.dst_addr.port() [destination/receive port, network order] API. This caused port based remapping based on the receive port to fail with ATS 6.0.0.
Contributor
Author
|
Change made as requested. Not sure how I missed that on the original change but in any case its fixed now :-) |
asfgit
pushed a commit
that referenced
this pull request
Jan 22, 2016
…57 changes. This closes #375. During the rework of RemapProcessor.cc, RemapProcessor::setup_for_remap() as part of the TS-2157 changeset, the port access API appears to have been incorrectly modified to use the client_info.src_addr.host_order_port() API [source port, host order] instead of the client_info.dst_addr.port() [destination/receive port, network order] API. This caused port based remapping based on the receive port to fail with ATS 6.0.0. (cherry picked from commit 894ef7f)
SolidWallOfCode
pushed a commit
to SolidWallOfCode/trafficserver
that referenced
this pull request
Feb 1, 2017
…57 changes. This closes apache#375. During the rework of RemapProcessor.cc, RemapProcessor::setup_for_remap() as part of the TS-2157 changeset, the port access API appears to have been incorrectly modified to use the client_info.src_addr.host_order_port() API [source port, host order] instead of the client_info.dst_addr.port() [destination/receive port, network order] API. This caused port based remapping based on the receive port to fail with ATS 6.0.0. Conflicts: lib/luajit
maskit
pushed a commit
to maskit/trafficserver
that referenced
this pull request
Feb 2, 2017
* asf/master: Doc: Typo "inorder" -> "in order" TS-4097: clang-format This closes apache#403. TS-4109: fix ts.debug/ts.error problem with long string TS-4096: update documentation TS-4096: ts.now() should return subsecond info for ts_lua plugin This closes apache#399. doc: fix a typo in traffic_via command reference TS-4105: RecDumpRecords passes the wrong record type to its callback TS-4097: Encode empty string properly with HPACK Format: Clang formatting. TS-3235: fix crash problem caused by sync problem in PluginVC. This closes apache#164. TS-4094: Clean up RD data in RequestData. This close apache#396. TS-4070: RemapProcessor Forward Mapping w/ Recv Port failing w/ TS-2157 changes. This closes apache#375. TS-4009: take continuation mutexes in stale_while_revalidate Bump the version to v6.2.0, we branched for 6.1.0 TS-4101: remove unused proxy.config.stats.config_file Generic: Remove excess semi-colons and commented out members. This close apache#388. TS-4083: CID 1343347: Fix unchecked return value. This closes apache#392
shinrich
added a commit
to shinrich/trafficserver
that referenced
this pull request
Feb 14, 2017
shinrich
added a commit
to shinrich/trafficserver
that referenced
this pull request
Mar 1, 2017
SolidWallOfCode
pushed a commit
to SolidWallOfCode/trafficserver
that referenced
this pull request
Apr 7, 2017
SolidWallOfCode
pushed a commit
to SolidWallOfCode/trafficserver
that referenced
this pull request
Jun 17, 2017
a-canary
pushed a commit
to a-canary/trafficserver
that referenced
this pull request
Jun 23, 2017
shinrich
added a commit
to shinrich/trafficserver
that referenced
this pull request
Jul 10, 2017
shinrich
added a commit
to shinrich/trafficserver
that referenced
this pull request
Jul 15, 2017
shinrich
added a commit
to shinrich/trafficserver
that referenced
this pull request
Jan 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…-2157 changes
During the rework of RemapProcessor.cc, RemapProcessor::setup_for_remap()
as part of the TS-2157 changeset, the port access API appears to have been
incorrectly modified to use the client_info.src_addr.host_order_port() API
[source port, host order] instead of the client_info.dst_addr.port()
[destination/receive port, network order] API. This caused port based
remapping based on the receive port to fail with ATS 6.0.0.