-
Notifications
You must be signed in to change notification settings - Fork 849
lua plugin: add support for relative path scripts; moves inline script to switch #4924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
i think it looks good. Just a small comment. |
80b7191 to
1498da5
Compare
|
[approve ci autest] |
|
I think you still make a good catch on line 204 on ts_lua_util.c that it is showing the error message with wrong parameter. So I recommend just to eliminate the "conf->script" parameter from the message altogether. thanks. If not, I can do it on my own tonight as well. Anyway, the rest all looks good. thanks. |
1498da5 to
1bdd74d
Compare
|
Do we need a small doc update with this? |
|
@mlibbey What do you have in mind here? |
|
The doc has this example Then some place in the config section, perhaps |
|
I can add that in the weekend if Randall does not beat me to that. |
|
Cherry-picked to 8.1.x |
To use inline scripts, prefix with --inline;
eg:
@plugin=tslua.so @pparam=--states=4 @pparam=--inline=print(123)