Skip to content

Conversation

@randall
Copy link
Contributor

@randall randall commented Feb 4, 2019

To use inline scripts, prefix with --inline;
eg:
@plugin=tslua.so @pparam=--states=4 @pparam=--inline=print(123)

@randall randall added this to the 9.0.0 milestone Feb 4, 2019
@randall randall self-assigned this Feb 4, 2019
@randall randall requested a review from shukitchan February 4, 2019 20:51
@shukitchan
Copy link
Contributor

i think it looks good. Just a small comment.

@randall randall force-pushed the ts_lua_relative_paths branch from 80b7191 to 1498da5 Compare February 5, 2019 15:21
@randall
Copy link
Contributor Author

randall commented Feb 5, 2019

[approve ci autest]

@shukitchan
Copy link
Contributor

I think you still make a good catch on line 204 on ts_lua_util.c that it is showing the error message with wrong parameter. So I recommend just to eliminate the "conf->script" parameter from the message altogether. thanks.

If not, I can do it on my own tonight as well.

Anyway, the rest all looks good. thanks.

…t to switch

To use inline scripts, prefix with --inline;
eg:
   @plugin=tslua.so @pparam=--states=4 @pparam=--inline=print(123)
@randall randall force-pushed the ts_lua_relative_paths branch from 1498da5 to 1bdd74d Compare February 5, 2019 18:47
@shukitchan shukitchan merged commit 21c82cf into apache:master Feb 5, 2019
@mlibbey
Copy link
Contributor

mlibbey commented Feb 7, 2019

Do we need a small doc update with this?

@randall randall deleted the ts_lua_relative_paths branch February 7, 2019 16:37
@randall
Copy link
Contributor Author

randall commented Feb 7, 2019

@mlibbey What do you have in mind here?

@mlibbey
Copy link
Contributor

mlibbey commented Feb 7, 2019

The doc has this example
@pparam=/XXX/test_hdr.lua
Perhaps, "The path referencing a file with the lua script can be relative to the configuration directory or an absolute path."

Then some place in the config section, perhaps
The remap line can contain inline script via the inline keyword. For example
@pparam=--inline=print(123)
would run those lua statements directly.

@shukitchan
Copy link
Contributor

I can add that in the weekend if Randall does not beat me to that.

@zwoop zwoop modified the milestones: 9.0.0, 8.1.0 Mar 19, 2020
@zwoop
Copy link
Contributor

zwoop commented Mar 19, 2020

Cherry-picked to 8.1.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants