lua plugin: fix for incorrectly injecting global plugin stats #6817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jvgutierrez
previously approved these changes
May 22, 2020
Contributor
Author
|
with the autest the traffic_ctl metric match is what's causing trouble. How to ensure it runs until the metrics show up? |
Contributor
|
It looks good. thanks. |
shukitchan
previously approved these changes
May 23, 2020
Contributor
Author
|
I hope I got it. My global lua script was an invalid global lua script. Fixing that seems to have fixed the autest. |
Contributor
Author
|
[approve ci autest] |
Contributor
|
[approve ci autest] |
shukitchan
approved these changes
May 27, 2020
Contributor
|
Cherry-picked to v9.0.x branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where the global lua plugin stats are incorrectly assigned causing a collision with remap plugins.