Skip to content

Conversation

@traeak
Copy link
Contributor

@traeak traeak commented May 19, 2020

Original PR (#6571)

(cherry picked from commit 8369634)

@jvgutierrez
Copy link
Member

After applying this PR we get two different issues in our instances, on the backend one:

May 20 15:14:34 cp5012 traffic_server[26855]: Fatal: attempted to register plugin.lua.remap.states twice

and on the TLS one:

May 20 15:15:24 cp5012 traffic_manager[25612]: NOTE: using cwd as TS_RUNROOT
May 20 15:15:24 cp5012 traffic_crashlog[27326]: NOTE: using cwd as TS_RUNROOT
May 20 15:15:24 cp5012 traffic_manager[25612]: [May 20 15:15:24.799] traffic_crashlo NOTE: crashlog started, target=27318, debug=false syslog=true, uid=116 euid=0
May 20 15:15:24 cp5012 traffic_crashlog[27326]: traffic_crashlo NOTE: crashlog started, target=27318, debug=false syslog=true, uid=116 euid=0
May 20 15:15:24 cp5012 traffic_manager[25612]: [May 20 15:15:24.800] traffic_crashlo NOTE: logging to 0x55b826dad260
May 20 15:15:24 cp5012 traffic_crashlog[27326]: traffic_crashlo NOTE: logging to 0x55b826dad260
May 20 15:15:25 cp5012 traffic_manager[25612]: [May 20 15:15:25.229] traffic_crashlo ERROR: wrote crash log to /srv/trafficserver/tls/var/log/crash-2020-05-20-151524.log
May 20 15:15:25 cp5012 traffic_crashlog[27326]: traffic_crashlo ERROR: wrote crash log to /srv/trafficserver/tls/var/log/crash-2020-05-20-151524.log
May 20 15:15:25 cp5012 traffic_manager[25612]: traffic_server: received signal 11 (Segmentation fault)
May 20 15:15:25 cp5012 traffic_manager[25612]: traffic_server - STACK TRACE:
May 20 15:15:25 cp5012 traffic_manager[25612]: /srv/trafficserver/tls/bin/traffic_server(_Z19crash_logger_invokeiP9siginfo_tPv+0xa0)[0x5568cf3500c0]
May 20 15:15:25 cp5012 traffic_manager[25612]: /lib/x86_64-linux-gnu/libpthread.so.0(+0x12730)[0x7f0c9c249730]
May 20 15:15:25 cp5012 traffic_manager[25612]: /usr/lib/trafficserver/modules/tslua.so(+0x8321)[0x7f0c8a2cd321]
May 20 15:15:25 cp5012 traffic_manager[25612]: /srv/trafficserver/tls/bin/traffic_server(_ZN15INKContInternal12handle_eventEiPv+0x9b)[0x5568cf35a96b]
May 20 15:15:25 cp5012 traffic_manager[25612]: /srv/trafficserver/tls/bin/traffic_server(_ZN7EThread13process_eventEP5Eventi+0x92)[0x5568cf636a22]
May 20 15:15:25 cp5012 traffic_manager[25612]: /srv/trafficserver/tls/bin/traffic_server(_ZN7EThread15execute_regularEv+0x2a2)[0x5568cf637a22]
May 20 15:15:25 cp5012 traffic_manager[25612]: /srv/trafficserver/tls/bin/traffic_server(+0x3b030a)[0x5568cf63630a]
May 20 15:15:25 cp5012 traffic_manager[25612]: /lib/x86_64-linux-gnu/libpthread.so.0(+0x7fa3)[0x7f0c9c23efa3]
May 20 15:15:25 cp5012 traffic_manager[25612]: /lib/x86_64-linux-gnu/libc.so.6(clone+0x3f)[0x7f0c9be474cf]

@traeak traeak force-pushed the 81x_lua_states_stats branch from 44c4ff8 to 1f13f34 Compare May 20, 2020 18:08
@traeak
Copy link
Contributor Author

traeak commented May 20, 2020

Thanks for the feedback. Rebasing this plugin in the 8.1.x branch so I can test it locally. This has seen a lot of synthetic testing.

@traeak traeak force-pushed the 81x_lua_states_stats branch from d9fa98c to 47c2069 Compare May 28, 2020 21:01
@traeak
Copy link
Contributor Author

traeak commented Jun 1, 2020

[approve ci autest]

@traeak traeak added Backport Marked for backport for an LTS patch release Lua Plugins labels Jun 2, 2020
@traeak traeak self-assigned this Jun 2, 2020
@jvgutierrez
Copy link
Member

we've been running this for a while on production without major issues

@jvgutierrez jvgutierrez self-requested a review June 5, 2020 10:12
@zwoop zwoop merged commit 9578748 into apache:8.1.x Jun 9, 2020
@zwoop zwoop added this to the 8.1.0 milestone Jun 9, 2020
@traeak traeak deleted the 81x_lua_states_stats branch January 13, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport Marked for backport for an LTS patch release Lua Plugins

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants