Update UDPNet for QUIC #5588
Merged
Update UDPNet for QUIC #5588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duke8253
approved these changes
Jun 6, 2019
Contributor
duke8253
left a comment
duke8253
left a comment
There was a problem hiding this comment.
Seems reasonable to me.
zwoop
requested changes
Jun 13, 2019
| #define SLOT_TIME HRTIME_MSECONDS(SLOT_TIME_MSEC) | ||
| #define N_SLOTS 2048 | ||
|
|
||
| constexpr int UDP_PERIOD = 9; |
Contributor
There was a problem hiding this comment.
Would we want to make this configurable? Under what conditions would I want to change it?
Member
Author
There was a problem hiding this comment.
No. Do not change this period unless you really know what happen after changing. It might callback twice per loop for one continuation in wrong configuration. So I give a constexpr here.
Member
Author
There was a problem hiding this comment.
If you really want to changing this period you might need to reconsider all of the continuations's order in udp's negative queue.
Member
Author
|
@zwoop Could you please review again ? |
Member
|
This is blocking merging QUIC branch, which will be a part of 9.0 release. Please review this as soon as possible.. |
zwoop
approved these changes
Jul 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
link to #5580
link to #3056