Skip to content

Fix crash in MIMEScanner::append with std::string. #5605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SolidWallOfCode merged 1 commit into from
Jun 7, 2019
Merged

Fix crash in MIMEScanner::append with std::string. #5605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions proxy/http2/Http2Stream.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -755,6 +755,7 @@ Http2Stream::destroy()
chunked_handler.clear();
clear_timers();
clear_io_events();
http_parser_clear(&http_parser);

super::destroy();
THREAD_FREE(this, http2StreamAllocator, this_ethread());
Expand Down
3 changes: 1 addition & 2 deletions proxy/http2/Http2Stream.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,6 @@ class Http2Stream : public ProxyTransaction
typedef ProxyTransaction super; ///< Parent type.
Http2Stream(Http2StreamId sid = 0, ssize_t initial_rwnd = Http2::initial_window_size) : client_rwnd(initial_rwnd), _id(sid)
{
http_parser_init(&http_parser);

SET_HANDLER(&Http2Stream::main_event_handler);
}

Expand All @@ -57,6 +55,7 @@ class Http2Stream : public ProxyTransaction
// FIXME: Are you sure? every "stream" needs request_header?
_req_header.create(HTTP_TYPE_REQUEST);
response_header.create(HTTP_TYPE_RESPONSE);
http_parser_init(&http_parser);
}

int main_event_handler(int event, void *edata);
Expand Down