Skip to content

Conversation

@SolidWallOfCode
Copy link
Member

I think this is a fix for #5587. The problem was Http2Stream wasn't calling the HTTP parser initialization and destruction correctly. http_parser_init needs to be called every initialization after a proxy allocate, not just in the constructor. Converserly, http_parser_clear needs to be called in the destroy method. Otherwise the parser (which contains the MIME scanner) is left in a bad state.

@SolidWallOfCode SolidWallOfCode added this to the 9.0.0 milestone Jun 6, 2019
@SolidWallOfCode SolidWallOfCode self-assigned this Jun 6, 2019
Copy link
Contributor

@masaori335 masaori335 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the initialization, http_parser_init() finally go to the MIMEScanner::init() and initialize the MIMEScanner::m_line with placement new correctly.

This looks reasonable.

@SolidWallOfCode SolidWallOfCode merged commit b7b6b4b into apache:master Jun 7, 2019
@zwoop zwoop modified the milestones: 9.0.0, 8.1.0 Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants