HTTP/2 backports for 8.1.x (part 3) #6599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I add 2 extra commits to pass clang-format and Debian/Ubuntu build.
|
(cherry picked from commit 0ee48a0) Conflicts: proxy/http2/Http2Stream.cc
(cherry picked from commit b7b6b4b) Conflicts: proxy/http2/Http2Stream.h
- No logical changes - Remove unnecessary include headers - Fix format - Make const functions (cherry picked from commit dc0fb99) Conflicts: iocore/eventsystem/I_VIO.h
…r HTTP/3 (cherry picked from commit 3ac74b5) Conflicts: proxy/http/HttpTransact.cc proxy/http2/Http2Stream.cc proxy/http2/Http2Stream.h
(cherry picked from commit 89cf5af) Conflicts: proxy/ProxyTransaction.cc proxy/ProxyTransaction.h proxy/http/HttpSM.h proxy/http2/Http2Stream.cc proxy/http2/Http2Stream.h
(cherry picked from commit c0fe598) Conflicts: tests/gold_tests/h2/gold/httpbin_0_stdout.gold tests/gold_tests/h2/httpbin.test.py
(cherry picked from commit fc4975d)
(cherry picked from commit 52538c4) Conflicts: proxy/http2/Http2ConnectionState.cc
(cherry picked from commit 9836b0b)
Prior to this change, HTTP/2 was almost 30% slower than HTTP/1.1 (over TLS) on downloading a huge file (over 1GB). Improvements: - Avoid unnecessary IOBufferBlock allocation for all type of frame - Avoid unnecessary copy on sending DATA frame - Adjust IOBufferBlock size of Http2ClientSession::write_buffer Cleanups: - Decouple receiving & sending HTTP/2 Frame - Remove unnecessary SCOPED_MUTEX_LOCK (cherry picked from commit 48bcbe6) Conflicts: proxy/http2/Http2ClientSession.cc proxy/http2/Http2ClientSession.h proxy/http2/Http2ConnectionState.cc proxy/http2/Http2Stream.cc
(cherry picked from commit 11aeedf)
(cherry picked from commit 582df40) Conflicts: .gitignore proxy/http2/HTTP2.h
(cherry picked from commit ca67471) Conflicts: proxy/http2/Http2Stream.cc
(cherry picked from commit 9bd2fd6)
(cherry picked from commit c55001b) Conflicts: proxy/http2/Http2Stream.cc
(cherry picked from commit 2868ce1)
(cherry picked from commit 7d4f66b)
(cherry picked from commit 7d37810)
(cherry picked from commit 240bb69) Conflicts: proxy/http2/Http2Stream.cc
(cherry picked from commit 87e7906) Conflicts: proxy/http2/Http2Stream.cc proxy/http2/Http2Stream.h
(cherry picked from commit 4094cda)
(cherry picked from commit deea85a)
We don't see this issue on master, because we got rid of TCL.
Contributor
Author
|
One more commit to fix AuTest failure following @ezelkow1 's advice. This is ready now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the third part of HTTP/2 backports to 8.1.x.
Backports:
#6003 - Cleanup: do not re-define _proxy_ssn variable in local
#5605 - Fix crash in MIMEScanner::append with std::string. See #5587.
#5920 - Cleanup: VIO
#5901 - Dechunk chunked contents on HttpTunnel if client protocol is HTTP/2 or HTTP/3
#5953 - Log H2 priority information
#6209 - Add 100-continue expectation support on H2 connection
#4912 - Address performance issue by removing use of read_avail
#6199 - Set END_STREAM flag when write_vio ntodo is 0
#6378 - Remove trailing white space from json formatter
#6337 - Perf: Optimize sending HTTP/2 frame
#6348 - Add virtual destructors for Http2TxFrame, Http2FrequencyCounter
#6568 - Fix PUSH_PROMISE frame payload length
#6346 - Fix heap-use-after-free on Http2Stream::destroy()
#5934 - Track scheduled events to (read|write)_vio.cont from Http2Stream
#5972 - Avoid unnecesarry copy on POST request over HTTP/2
#6404 - Signal VC_EVENT_READ_COMPLETE when ATS received END_STREAM flag
#6413 - Fix crash when H2 client does not set End-of-data bit
#6376 - Update inactive_timeout_at in Http2Stream::signal_read_event()
#6380 - Remove unnecesary HttpSM handler call with VC_EVENT_ERROR
#6409 - Another option to fix potential HTTP/2 vio stall
#6450 - Adjust consume logic in data frame read
#6470 - Remove update to unused variable