-
Notifications
You must be signed in to change notification settings - Fork 844
Log H2 priority information #5953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bryancall
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am OK with this.
|
This might give us some clue of H2 priority. But I'm bit wondering of the access log is the best way for logging H2 priority information, because the weight & dependence might be changed after the |
|
True, this will not identify changes due to explicit PRIORITY frames, but in my experience I haven't seen many of them. Just getting some visibility someplace was immensely useful for understanding unexpected behavior. This is better than my previous approach of creating one off builds with extra warning messages. Open to other ideas. Could be updated to override with information from the priority frames in a later PR. |
9522002 to
42bbf7a
Compare
42bbf7a to
d5e7f85
Compare
|
Finally pushed an update to address @masaori335's comment |
|
[approve ci] |
masaori335
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK - better than nothing
|
[approve ci] |
|
[approve ci autest] |
|
This is pending A-A-Ron's massive refactoring changes I think... |
|
Cherry-picked to v9.0.x branch. |
Adding format strings to log priority weight and dependence for a transaction so we can understand changes in performance characteristics when enabling HTTP/2 priority.