Skip to content

Fix PUSH_PROMISE frame payload length #6568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
masaori335 merged 1 commit into from
Mar 30, 2020
Merged

Fix PUSH_PROMISE frame payload length #6568

masaori335 merged 1 commit into from
Mar 30, 2020

Conversation

@masaori335
Copy link
Contributor

@masaori335 masaori335 commented Mar 26, 2020

Prior to this change, the payload length missed the length of Promised Stream ID. 48bcbe6 made this bug.

@masaori335 masaori335 added this to the 10.0.0 milestone Mar 26, 2020
@masaori335 masaori335 self-assigned this Mar 26, 2020
@masaori335 masaori335 merged commit 582df40 into apache:master Mar 30, 2020
@masaori335 masaori335 mentioned this pull request Mar 31, 2020
Merged
@zwoop zwoop modified the milestones: 10.0.0, 8.1.0 Apr 6, 2020
@zwoop
Copy link
Contributor

zwoop commented Apr 6, 2020

Cherry-picked to 9.0.x and 8.1.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maskit maskit maskit approved these changes

Assignees

@masaori335 masaori335

Labels

HTTP/2

Projects

None yet

Milestone

8.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@masaori335 @zwoop @maskit