Remove unnecesary HttpSM handler call with VC_EVENT_ERROR #6380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shinrich
approved these changes
Feb 5, 2020
Member
shinrich
left a comment
shinrich
left a comment
There was a problem hiding this comment.
Seems reasonable. It should fall through to the !sent_write_complete case, and the do_io_close() should signal the _sm if it exists. This is attempting to address an error-ful case which may not ever exists.
Contributor
|
Cherry-picked to v9.0.x branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the second issue of #6368.
IIUC, when
Http2Streamas aVConnectionsignalVC_EVENT_ERRORevent to the upper layer, avioshould be also given as a second argument.In the #6368 case, 1)
read_vio.contis nullptr and 2)write_vio.contis nullptr orVC_EVENT_WRITE_COMPLETEorVC_EVENT_EOSis already sent. Thus, thisVC_EVENT_ERRORlooks unnecessary.