Skip to content

Conversation

@masaori335
Copy link
Contributor

Fix httpbin autest.

       file /var/tmp/ausb-6370.12163/httpbin/_output/3-tr-Default/stream.stdout.txt : Checking that /var/tmp/ausb-6370.12163/httpbin/_output/3-tr-Default/stream.stdout.txt matches gold/httpbin_3_stdout.gold - Failed
          Reason: File differences
           Gold File : /var/jenkins/workspace/autest-github/src/tests/gold_tests/h2/gold/httpbin_3_stdout.gold
           Data File : /var/tmp/ausb-6370.12163/httpbin/_output/3-tr-Default/stream.stdout.txt
             {
               "files": {}, 
               "origin": "127.0.0.1", 
               "form": {
                 "key": "value"
           -   },
           +   }, 
           ?     +
           
               "url": "http://127.0.0.1:61743/post", 
               "args": {}, 
               "headers": {
                 "Content-Length": "9", 
                 "Client-Ip": "127.0.0.1", 
                 "Accept": "*/*", 
                 "User-Agent": "curl/7.65.0-DEV", 
                 "Host": "127.0.0.1:61743", 
                 "Expect": "100-continue", 
                 "Content-Type": "application/x-www-form-urlencoded"
               }, 
               "json": null, 
               "data": ""
             }

@masaori335 masaori335 added this to the 10.0.0 milestone Jan 30, 2020
@masaori335 masaori335 self-assigned this Jan 30, 2020
@shukitchan
Copy link
Contributor

[approve ci autest]

Copy link
Member

@SolidWallOfCode SolidWallOfCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that was annoying.

Copy link
Contributor

@zwoop zwoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good. We should investigate if we can avoid spawning a new Python here, since the version can be different. A fork() would be better if possible ?

@masaori335
Copy link
Contributor Author

I agree we should avoid spawning a new Python if possible. But the issue looks a bit general in AuTest. Let's merge this and fix them in other PRs. (Filed as #6387, #6386)

@masaori335 masaori335 merged commit 9836b0b into apache:master Feb 4, 2020
@masaori335 masaori335 added AuTest and removed Tests labels Feb 4, 2020
@zwoop
Copy link
Contributor

zwoop commented Feb 5, 2020

Cherry-picked to v9.0.x branch.

@zwoop zwoop modified the milestones: 10.0.0, 9.0.0 Feb 5, 2020
@zwoop zwoop modified the milestones: 9.0.0, 8.1.0 Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants