-
Notifications
You must be signed in to change notification settings - Fork 847
Set END_STREAM flag when write_vio ntodo is 0 #6199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It looks like simple check of |
|
The issue with 100 Continue response looks exists regardless of the dechunk cleanup changes. Filed as #6202. |
|
100 continue issue is addressed with new commit. I'll try applying the fix on the 8.0.x branch. |
shinrich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes also correctly return a header only in the case of reponse-less statuses like 304.
|
Will set up a performance build too. |
|
My test build on a prod box is looking good so far with respect to latency. Average latency staying around 120ms which is what I was seeing before the Dechunk changes. I'll build an official build tomorrow so I'm certain that I'm running the right thing. But so far, so good. |
|
Pushed new commits. Logics are almost the same as before.
|
|
Oops, since there were two commits here, I missed one. I've cherry-picked both of these to the v9.0.x branch. |
Another approach to fix #6178.