Mark EOS on Http/2 Header for responses without body #6196
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Closing in deference to PR #6199 |
Contributor
|
Remember to remove Project / Milestones from PRs that are closed without merging. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this addresses the performance issue reported in Issue #6178
As noted there, a new commit from @masaori335 cleaned up the chunked data processing. The HTTP/2 implementation was relying on that to send empty DATA frames with the EOS bit set to finish the transaction instead of setting the EOS bit on the response header.
This PR detects methods and return codes that will not send a response body, so the HEADER frame can have the EOS bit set directly, and avoid the inactivity timeout.