Cleanup: Fixes for a more stringent g++ compiler. #6046
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Looks like I need #6043 in here as well. |
SolidWallOfCode
force-pushed
the
gcc-fixup
branch
from
21e75f5 to
d963cfc
Compare
Member
Author
|
Added tweak for the image magick plugin to the base commit. |
Contributor
|
I ended up tracking down all the PRs and cherry picking them into the 8.0.x branch and then making a 3 line change in this PR #6088, where I couldn't find these changes to cherry-pick. ATS 8.0.6 will now support clang 8 and gcc9 without compiler warnings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears to me the problem is a more stringent g++ compiler. Many (if not most) of these issues are in code that hasn't been touched for years (e.g., "Map.h"). I also think many of these were done for ATS 9, but those PRs weren't pulled back. The fixes were simple enough it was easier to just do them again, or just copy from master.