Cleanup: Fixes for a more stringent g++ compiler.

CMakeLists.txt

@@ -396,7 +396,6 @@ add_executable(ats
         src/wccp/WccpMsg.cc
         src/wccp/WccpStatic.cc
         src/wccp/WccpUtil.h
-        lib/ink_autoconf.h
         mgmt/api/include/mgmtapi.h
         mgmt/api/APITestCliRemote.cc
         mgmt/api/CoreAPI.cc
@@ -814,7 +813,6 @@ add_executable(ats
         proxy/http2/HuffmanCodec.h
         proxy/http2/RegressionHPACK.cc
         proxy/http2/test_HPACK.cc
-        proxy/http2/test_Http2DependencyTree.cc
         proxy/http2/test_Huffmancode.cc
         proxy/logging/Log.cc
         proxy/logging/Log.h
@@ -893,7 +891,6 @@ add_executable(ats
         proxy/Show.h
         proxy/StatPages.cc
         proxy/StatPages.h
-        proxy/TimeTrace.h
         proxy/Transform.cc
         proxy/Transform.h
         proxy/TransformInternal.h
@@ -916,8 +913,6 @@ add_library(libtscore SHARED
         include/tscore/Arena.h
         src/tscore/BaseLogFile.cc
         include/tscore/BaseLogFile.h
-        src/tscore/Bitops.cc
-        include/tscore/Bitops.h
         include/tscore/bwf_std_format.h
         include/tscore/BufferWriter.h
         include/tscore/BufferWriterForward.h
@@ -1065,17 +1060,13 @@ add_library(libtscore SHARED
         include/tscore/SimpleTokenizer.h
         src/tscore/SourceLocation.cc
         include/tscore/SourceLocation.h
-        src/tscore/test_arena.cc
         src/tscore/test_atomic.cc
         src/tscore/test_freelist.cc
         src/tscore/test_geometry.cc
         src/tscore/test_History.cc
-        src/tscore/test_List.cc
-        src/tscore/test_Map.cc
         src/tscore/test_PriorityQueue.cc
         src/tscore/test_Ptr.cc
         src/tscore/test_Regex.cc
-        src/tscore/test_Vec.cc
         src/tscore/test_X509HostnameValidator.cc
         include/tscore/TestBox.h
         src/tscore/TestHttpHeader.cc
@@ -1190,7 +1181,6 @@ add_library(plugin_escalate SHARED
 
 # CacheTool
 add_executable(traffic_cache_tool
-	src/traffic_cache_tool/CacheStore.h
 	src/traffic_cache_tool/CacheDefs.h
 	src/traffic_cache_tool/CacheDefs.cc
 	src/traffic_cache_tool/CacheTool.cc

include/tscore/BufferWriter.h

@@ -207,6 +207,9 @@ class BufferWriter
 };
 
 /** A @c BufferWrite concrete subclass to write to a fixed size buffer.
+ *
+ * Copies and moves are forbidden because that leaves the original in a potentially bad state. An
+ * instance is cheap to construct and should be done explicitly when needed.
  */
 class FixedBufferWriter : public BufferWriter
 {
@@ -231,10 +234,8 @@ class FixedBufferWriter : public BufferWriter
 
   FixedBufferWriter(const FixedBufferWriter &) = delete;
   FixedBufferWriter &operator=(const FixedBufferWriter &) = delete;
-  /// Move constructor.
-  FixedBufferWriter(FixedBufferWriter &&) = default;
-  /// Move assignment.
-  FixedBufferWriter &operator=(FixedBufferWriter &&) = default;
+  FixedBufferWriter(FixedBufferWriter &&)                 = delete;
+  FixedBufferWriter &operator=(FixedBufferWriter &&) = delete;
 
   FixedBufferWriter(MemSpan &span) : _buf(span.begin()), _capacity(static_cast<size_t>(span.size())) {}
 

include/tscore/ContFlags.h

@@ -41,8 +41,9 @@ class ContFlags
 public:
   enum flags { DEBUG_OVERRIDE = 0, DISABLE_PLUGINS = 1, LAST_FLAG };
 
-  ContFlags() {}
-  ContFlags(uint32_t in_flags) : raw_flags(in_flags) {}
+  constexpr ContFlags() {}
+  constexpr ContFlags(ContFlags const &that) = default;
+  constexpr ContFlags(uint32_t in_flags) : raw_flags(in_flags) {}
   void
   set_flags(uint32_t new_flags)
   {

include/tscore/CryptoHash.h

@@ -47,6 +47,7 @@ union CryptoHash {
 
   /// Default constructor - init to zero.
   CryptoHash() { memset(this, 0, sizeof(*this)); }
+  CryptoHash(CryptoHash const &that) = default;
 
   /// Assignment - bitwise copy.
   CryptoHash &

include/tscore/Map.h

@@ -1150,6 +1150,7 @@ template <class K, class C> class MapElem
   MapElem(K const &akey, C const &avalue) : key(akey), value(avalue) {}
   MapElem(MapElem const &e) : key(e.key), value(e.value) {}
   MapElem() : key(), value() {}
+  MapElem &operator=(MapElem const &that) = default;
 };
 
 template <class K, class C, class A = DefaultAlloc> class Map : public Vec<MapElem<K, C>, A>

include/tscore/MemSpan.h

@@ -53,6 +53,8 @@ class MemSpan
   /// Default constructor (empty buffer).
   constexpr MemSpan();
 
+  constexpr MemSpan(self_type const &that) = default;
+
   /** Construct explicitly with a pointer and size.
    */
   constexpr MemSpan(void *ptr,  ///< Pointer to buffer.

include/tscore/ink_uuid.h

@@ -33,8 +33,9 @@ class ATSUuid
 {
 public:
   // Constructors
-  ATSUuid() : _version(TS_UUID_UNDEFINED) {}
-  ATSUuid &operator=(const ATSUuid other);
+  ATSUuid()                    = default;
+  ATSUuid(ATSUuid const &that) = default;
+  ATSUuid &operator            =(const ATSUuid other);
 
   // Initialize the UUID from a string
   bool parseString(const char *str);
@@ -122,7 +123,7 @@ class ATSUuid
   } _uuid;
 
   // This is the typically used visible portion of the UUID
-  TSUuidVersion _version;
+  TSUuidVersion _version = TS_UUID_UNDEFINED;
   char _string[TS_UUID_STRING_LEN + 1];
 
   bool

iocore/cache/I_Store.h

@@ -174,7 +174,7 @@ struct Span {
   /// at every call site. We also need this because we have ats_scoped_str members.
   Span(Span const &that)
   {
-    memcpy(this, &that, reinterpret_cast<intptr_t>(&(static_cast<Span *>(nullptr)->pathname)));
+    memcpy(static_cast<void *>(this), &that, reinterpret_cast<intptr_t>(&(static_cast<Span *>(nullptr)->pathname)));
     if (that.pathname) {
       pathname = ats_strdup(that.pathname);
     }

iocore/net/P_Connection.h

@@ -132,6 +132,7 @@ struct Connection {
 
   virtual ~Connection();
   Connection();
+  Connection(Connection const &) = delete;
 
   /// Default options.
   static NetVCOptions const DEFAULT_OPTIONS;
@@ -141,11 +142,6 @@ struct Connection {
    */
   void move(Connection &);
 
-private:
-  // Don't want copy constructors to avoid having the deconstructor on
-  // temporarly copies close the file descriptor too soon. Use move instead
-  Connection(Connection const &);
-
 protected:
   void _cleanup();
 };