Skip to content

[TS-4437] Add new limit rate example plugin #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yatsukhnenko wants to merge 0 commits into from
Closed

[TS-4437] Add new limit rate example plugin #615

yatsukhnenko wants to merge 0 commits into from

Conversation

@yatsukhnenko
Copy link
Contributor

@yatsukhnenko yatsukhnenko commented May 4, 2016

No description provided.

@zwoop
Copy link
Contributor

zwoop commented May 6, 2016

Taking a quick look, two comments:

  1. You must add the AL2 license blurb to all new files.

  2. As is, this does belong as an example. I'm wondering / hoping that we'd eventually turn this into a real plugin?

@yatsukhnenko
Copy link
Contributor Author

yatsukhnenko commented May 10, 2016

  1. done
  2. I used vconn and timer to control a portioning of data. What do you think about that? Maybe it should be done on the "lower" level or maybe we should use different algorithm?
    What else we need to turn this in real plugin? :)

@zwoop
Copy link
Contributor

zwoop commented May 11, 2016

Also, would you mind adding the Jira number to the Subject line to this commit / PR? It helps us associate the PR with the correct Jira.

@yatsukhnenko
Copy link
Contributor Author

yatsukhnenko commented May 12, 2016

There is no Jira for this PR and I can't create new issue :(

@zwoop
Copy link
Contributor

zwoop commented May 12, 2016

Not sure why you couldn't create the Jira, but I made one for you: https://issues.apache.org/jira/browse/TS-4437. All you should have to do is to register with the Jira instance, and anyone can create Jira's against ATS.

@zwoop zwoop added the Plugins label May 12, 2016
@yatsukhnenko yatsukhnenko changed the title Add new limit rate example plugin [TS-4437] Add new limit rate example plugin May 13, 2016
@zwoop zwoop added this to the 7.0.0 milestone May 15, 2016
@zwoop zwoop modified the milestone: 7.0.0 May 4, 2017
ywkaras pushed a commit to ywkaras/trafficserver that referenced this pull request Jul 7, 2022
@bneradt @SolidWallOfCode
Update HostDBContinuation timeout handling to clear pending queue. (a…
e3f584d 
…pache#8480) (apache#615)

Closes apache#8417
(cherry picked from commit bfd5f89)

Conflicts:
	iocore/hostdb/HostDB.cc

Co-authored-by: Alan M. Carroll <amc@apache.org>
masaori335 pushed a commit to masaori335/trafficserver that referenced this pull request Sep 26, 2023
@jhiapple
For xdebug plugin, add doublequotes around the URL of X-Effective-URL. (
bbbd6d8 
apache#9899) (apache#615)

* Add doublequotes around the URL of X-Effective-URL.

URLs can have commas which makes the URLs fragile when multiple URLs are returned,
and the values of multiple X-Effective-URL headers are merged.

Follow-up on 170e12b (Adds new X-Effective-URL header to the xdebug plugin (apache#7931))

* Document the X-Effective-URL.

(cherry picked from commit 7016476)

Co-authored-by: jhiapple <85640167+jhiapple@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Plugins

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yatsukhnenko @zwoop