Adds new X-Effective-URL header to the xdebug plugin

[jhiapple]

By adding "X-Effective-URL" to the request header "X-Debug",
the header "X-Effective-URL" header will be inserted to the
request headers with the effective URL value.

Exposes the TSHttpTxnEffectiveUrlStringGet() result, which is
the URL after the remap.

Note: the inserted header is intentionally X-prefixed for consistency
with the other headers inserted by the xdebug plugin.

[bryancall]

I will review it

[ywkaras]

Do we want this in 9.2 or not until 10?

[zwoop]

We can add this to 9.2.x.

[ywkaras]

You could move this between lines 397 and 398, and eliminate this if statement. Once you did that, you could declare dst on line 395 and delete line 303.

[jhiapple]

On 14. Jul 2021, at 0.40, Walt Karas ***@***.***> wrote: @ywkaras commented on this pull request. In plugins/xdebug/xdebug.cc <#7931 (comment)>: > + int len; + } strval = {nullptr, 0}; + + TSDebug("xdebug", "attempting to inject X-Effective-URL header"); + + strval.ptr = TSHttpTxnEffectiveUrlStringGet(txn, &strval.len); + + if (strval.ptr != nullptr && strval.len > 0) { + dst = FindOrMakeHdrField(buffer, hdr, "X-Effective-URL", lengthof("X-Effective-URL")); + if (dst != TS_NULL_MLOC) { + TSReleaseAssert(TSMimeHdrFieldValueStringInsert(buffer, hdr, dst, -1 /* idx */, strval.ptr, strval.len) == TS_SUCCESS); + } + } + + if (dst != TS_NULL_MLOC) { + TSHandleMLocRelease(buffer, hdr, dst); You could move this between lines 397 and 398, and eliminate this if statement. Once you did that, you could declare dst on line 395 and delete line 303.

Tighter scope nice, so done in 60252d5

…

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#7931 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AUNMHZ63AILPY54BHQIRUYTTXSXDNANCNFSM46MQSQMA>.