TS-4309: Simplify read/write loops to address upload/download speed p… #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Warning("Cannot add new block"); | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
I believe these code will read SSL data until meet EAGAIN. How to handle a SSL flood attack ? a fast socket keeps sending and keeps call SSLReadBuffer and add_block() there no chance to return to NetHandler::manNetEvent() to processing next NetVC.
There was a problem hiding this comment.
Good point. Looking at the non-ssl version, it is tracking a max to read. We should do something similar in the ssl-case.
oknet
added a commit
to oknet/trafficserver
that referenced
this pull request
May 31, 2016
ogoodman
pushed a commit
to ogoodman/trafficserver
that referenced
this pull request
Aug 20, 2016
…roblems. This closes apache#629.
shinrich
added a commit
to shinrich/trafficserver
that referenced
this pull request
Jan 9, 2018
Fix make check
ywkaras
pushed a commit
to ywkaras/trafficserver
that referenced
this pull request
Jul 7, 2022
In TsSharedMutex.h, make error reporting thread-safe. (apache#8636)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…roblems.
May also help with ASAN crash reported in TS-4424.