In TsSharedMutex.h, make error reporting thread-safe. #8636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywkaras
force-pushed
the
cstring_TsSharedMutex
branch
from
f9e371c to
72209a9
Compare
ywkaras
changed the title
ywkaras
force-pushed
the
cstring_TsSharedMutex
branch
2 times, most recently
from
7e0c281 to
a79511f
Compare
|
@serrislew is going to look at this |
ywkaras
force-pushed
the
cstring_TsSharedMutex
branch
from
a79511f to
cdcbc6f
Compare
serrislew
reviewed
Feb 2, 2022
| Strerror(int err_num) | ||
| { | ||
| _c_str = strerror_r(err_num, _buf, 256); | ||
| if (!_c_str) { |
There was a problem hiding this comment.
some docs show that with the GNU-specific strerror_r(), if err_num is unknown, it can return an "unknown error nnn" message which won't make _c_str null, making the conditional think that strerror_r() did not fail when it did. Maybe use the XSI-compliant version (returning int) and returning _buf which also has the error string
There was a problem hiding this comment.
TS is compiled with -D_GNU_SOURCE, which means that only the GNU-specific strerror_r() is available. Even if it never returns null (currently), I'd rather leave the handling in for future-safety.
There was a problem hiding this comment.
This breaks build on macOS #8642
vmamidi
approved these changes
Feb 2, 2022
zwoop
pushed a commit
that referenced
this pull request
Feb 17, 2022
(cherry picked from commit 4b0d3cb)
|
Cherry-picked to v9.2.x |
moonchen
pushed a commit
to moonchen/trafficserver
that referenced
this pull request
Mar 17, 2022
* asf/9.2.x: Revert "DNS: Fix lack of nameserver failover in low use circumstances. (apache#7843)" (apache#8663) Fix strategies to initialize scheme (apache#8650) DNS: Fix lack of nameserver failover in low use circumstances. (apache#7843) Cleanup strategy debug logs (apache#8656) Making 9.2.x backwards compatible with 9.1.x (apache#8661) Adds two overridable config variables to control parent mark downs. (apache#8595) Fix plugin parent_select missing hostname len (apache#8649) Ports apache#7925 apache#8365 core to parent_select plugin (apache#8590) Ports apache#7897 from core strategies to parent_select plugin. (apache#8580) Adding clangd language server files to .gitignore (apache#8640) Make TsSharedMutex.h compile on MacOS. (apache#8645) In TsSharedMutex.h, make error reporting thread-safe. (apache#8636) Revert "body factory does not respect runroot (apache#8388)" (apache#8654) doc: Convert miscased Traffic Server references to |TS| macro (apache#8543) Add a new --enable-event-tracker configure option (apache#8179) Add parent_select plugin strategy caching (apache#8651) TLS Session Resumption: fix timed out session (apache#8667) Fix to allow running from outside top_srcdir (apache#8673) Send diags output to stderr when running regression tests. (apache#8662) Default proxy.config.http.strict_uri_parsing to "2" (apache#8632)
ywkaras
pushed a commit
to ywkaras/trafficserver
that referenced
this pull request
Jul 7, 2022
(cherry picked from commit 4b0d3cb)
ywkaras
pushed a commit
to ywkaras/trafficserver
that referenced
this pull request
Jul 7, 2022
In TsSharedMutex.h, make error reporting thread-safe. (apache#8636)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.