Port #7925 and #8365 from core strategies to parent_select plugin #8590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rob05c
force-pushed
the
port-strategy-findNextHop-changes
branch
from
8905dbf to
7a65ccc
Compare
rob05c
changed the title
rob05c
force-pushed
the
port-strategy-findNextHop-changes
branch
from
7a65ccc to
ede99b0
Compare
|
Can you, as a part of this PR, create versions of the Au tests zzz_strategies_peer.test.py and zzz_strategies_peer2.test.py that utilize the plugin rather than strategies.yaml? |
rob05c
force-pushed
the
port-strategy-findNextHop-changes
branch
from
ede99b0 to
04a4e29
Compare
rob05c
force-pushed
the
port-strategy-findNextHop-changes
branch
from
04a4e29 to
5b63da3
Compare
Done. |
rob05c
force-pushed
the
port-strategy-findNextHop-changes
branch
from
5b63da3 to
b68b14d
Compare
ywkaras
previously approved these changes
Jan 14, 2022
Ports apache#7925 and apache#8365 from core strategies to parent_select plugin. PR apache#7925 adds go_direct support to peering_ring strategies. PR apache#8365 refactors strategy consistent hashing to fix a bug. They both essentially completely rewrite the strategy consistent hashing, so it was safer and easier to port them both at the same time. Add parent_select plugin autests Tests are mostly copied from the core strategies tests, which makes sense since the plugin strategies should behave the same as core.
rob05c
force-pushed
the
port-strategy-findNextHop-changes
branch
from
b68b14d to
c89b77e
Compare
ywkaras
reviewed
Jan 28, 2022
| @@ -297,6 +320,8 @@ PLNextHopConsistentHash::next(TSHttpTxn txnp, void *strategyTxn, const char *exc | |||
|
|
|||
| PL_NH_Debug(PL_NH_DEBUG_TAG, "nextParent NH plugin calling"); | |||
|
|
|||
| uint32_t const NO_RING_USE_POST_REMAP = uint32_t(0) - 1; | |||
There was a problem hiding this comment.
Constructor-style casts are not Leif-legal but hopefully he won't see it.
There was a problem hiding this comment.
I didn't write this, this PR is just porting the existing code/changes in core to the plugin
https://github.com/apache/trafficserver/blob/3e8f2eba/proxy/http/remap/NextHopConsistentHash.cc#L235
ywkaras
approved these changes
Jan 28, 2022
zwoop
pushed a commit
that referenced
this pull request
Feb 17, 2022
Ports #7925 and #8365 from core strategies to parent_select plugin. PR #7925 adds go_direct support to peering_ring strategies. PR #8365 refactors strategy consistent hashing to fix a bug. They both essentially completely rewrite the strategy consistent hashing, so it was safer and easier to port them both at the same time. Add parent_select plugin autests Tests are mostly copied from the core strategies tests, which makes sense since the plugin strategies should behave the same as core. (cherry picked from commit d7b1154)
|
Cherry-picked to v9.2.x |
moonchen
pushed a commit
to moonchen/trafficserver
that referenced
this pull request
Mar 17, 2022
* asf/9.2.x: Revert "DNS: Fix lack of nameserver failover in low use circumstances. (apache#7843)" (apache#8663) Fix strategies to initialize scheme (apache#8650) DNS: Fix lack of nameserver failover in low use circumstances. (apache#7843) Cleanup strategy debug logs (apache#8656) Making 9.2.x backwards compatible with 9.1.x (apache#8661) Adds two overridable config variables to control parent mark downs. (apache#8595) Fix plugin parent_select missing hostname len (apache#8649) Ports apache#7925 apache#8365 core to parent_select plugin (apache#8590) Ports apache#7897 from core strategies to parent_select plugin. (apache#8580) Adding clangd language server files to .gitignore (apache#8640) Make TsSharedMutex.h compile on MacOS. (apache#8645) In TsSharedMutex.h, make error reporting thread-safe. (apache#8636) Revert "body factory does not respect runroot (apache#8388)" (apache#8654) doc: Convert miscased Traffic Server references to |TS| macro (apache#8543) Add a new --enable-event-tracker configure option (apache#8179) Add parent_select plugin strategy caching (apache#8651) TLS Session Resumption: fix timed out session (apache#8667) Fix to allow running from outside top_srcdir (apache#8673) Send diags output to stderr when running regression tests. (apache#8662) Default proxy.config.http.strict_uri_parsing to "2" (apache#8632)
zwoop
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports #7925 and #8365 from core strategies to parent_select plugin.
PR #7925 adds go_direct support to peering_ring strategies.
PR #8365 refactors strategy consistent hashing to fix a bug.
They both essentially completely rewrite the strategy consistent
hashing, so it was safer and easier to port them both at the same
time.
This PR is based on #8580 - recommend merging that first.