Port #7749 from core strategy to plugin #8571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ports apache#7749 fix for core strategies to the parent_select plugin. Fixes a crash when a strategy has a bad 'to' URL, which manifests as a missing null pointer check.
rob05c
force-pushed
the
port-strategy-plugin-7749
branch
from
a84d23f to
a2c9085
Compare
bneradt
approved these changes
Jan 4, 2022
traeak
approved these changes
Jan 5, 2022
Contributor
traeak
left a comment
traeak
left a comment
There was a problem hiding this comment.
Probably should be using nullptr in compares (ie: (nullptr != pRec) instead of just (pRec)) but it is consistent with the rest of the code.
Contributor
|
Cherry-picked to v9.2.x |
moonchen
pushed a commit
to moonchen/trafficserver
that referenced
this pull request
May 26, 2022
Ports apache#7749 fix for core strategies to the parent_select plugin. Fixes a crash when a strategy has a bad 'to' URL, which manifests as a missing null pointer check. (cherry picked from commit 03267ba)
moonchen
pushed a commit
to moonchen/trafficserver
that referenced
this pull request
May 26, 2022
* asf/9.2.x: Updated ChangeLog Fixes build when hwloc is not installed (apache#8715) update FREELIST macros for AArch64 (apache#8688) Move hwloc-based functions into it's own header/compilation unit (apache#8711) Include CPPFLAGS when building CompileParseRules (apache#8445) Port apache#7837 from core strategy to plugin (apache#8573) Port apache#7749 from core strategy to plugin (apache#8571) Port apache#6816 from core strategy to plugin (apache#8570) Add back "DNS: Fix lack of nameserver failover in low use circumstances." (apache#8705) Update iocore/cache/test to fix the build (apache#8677) Provide libquic.a definition to VIO::VIO() (apache#8706) Add docs for parent.config defaults (apache#8692) cache-request-method autest: Extending IO delay (apache#8707)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports #7749 fix for core strategies to the parent_select plugin.
Fixes a crash when a strategy has a bad 'to' URL, which manifests as a
missing null pointer check.