Fixes remaining memory leaks with nexthop strategy unit tests #6816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
found by ASAN. This should close issue 6765
jrushford
added
Backport
bryancall
approved these changes
May 21, 2020
rob05c
added a commit
to rob05c/trafficserver
that referenced
this pull request
Jan 3, 2022
Ports apache#6816 fix for core strategies to the parent_select plugin. Fixes a bug with the YAML loading calling opendir but not closedir, which leaked the file descriptor.
traeak
pushed a commit
that referenced
this pull request
Jan 5, 2022
zwoop
pushed a commit
that referenced
this pull request
Mar 10, 2022
moonchen
pushed a commit
to moonchen/trafficserver
that referenced
this pull request
May 26, 2022
Ports apache#6816 fix for core strategies to the parent_select plugin. Fixes a bug with the YAML loading calling opendir but not closedir, which leaked the file descriptor. (cherry picked from commit ca3654c)
moonchen
pushed a commit
to moonchen/trafficserver
that referenced
this pull request
May 26, 2022
* asf/9.2.x: Updated ChangeLog Fixes build when hwloc is not installed (apache#8715) update FREELIST macros for AArch64 (apache#8688) Move hwloc-based functions into it's own header/compilation unit (apache#8711) Include CPPFLAGS when building CompileParseRules (apache#8445) Port apache#7837 from core strategy to plugin (apache#8573) Port apache#7749 from core strategy to plugin (apache#8571) Port apache#6816 from core strategy to plugin (apache#8570) Add back "DNS: Fix lack of nameserver failover in low use circumstances." (apache#8705) Update iocore/cache/test to fix the build (apache#8677) Provide libquic.a definition to VIO::VIO() (apache#8706) Add docs for parent.config defaults (apache#8692) cache-request-method autest: Extending IO delay (apache#8707)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes all the remaining memory leaks detected in the next hop strategy unit-tests found by ASAN. An actual file descriptor leak was identified by the address sanitizer in NextHopStrategyFactory.cc when using opendir() to read a directory. The directory was not getting closed, this has been fixed This should close issue 6765.
This PR should be back ported to ATS 9.0.