TSHttpTxnCacheLookupStatusGet: call need_to_revalidate #8617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts apache#8548 and instead directly calls HttpTransact::need_to_revalidate in TSHttpTxnCacheLookupStatusGet to ensure that an object which is a cache hit is indeed something ATS can return to the client. Fixes apache#8616
Contributor
Author
|
[approve ci debian] |
Contributor
Author
|
[approve ci] |
masaori335
approved these changes
Jan 19, 2022
Contributor
masaori335
left a comment
masaori335
left a comment
There was a problem hiding this comment.
Looks reasonable. The root cause is explained in #8616 (comment) .
It looks like with #8484, the need_to_revalidate revalidate function is no longer called before TSHttpTxnCacheLookupStatusGet is called, and thus the cache_hit_but_revalidate flag isn't set yet.
Contributor
|
/cc @serrislew |
bneradt
deleted the
call_need_to_revalidate_in_TSHttpTxnCacheLookupStatusGet
branch
Contributor
|
Cherry-picked to v9.2.x |
bneradt
added a commit
to bneradt/trafficserver
that referenced
this pull request
Jan 31, 2022
Fixing apache#8539 is easy to do in a common case, but it causing issues in corner cases. For now I'm going to revert the fixes for this and circle back around later to see whether this can be solved in a different way. This reverts the following commits: Revert "Commenting TSHttpTxnCacheLookupStatusGet need_to_revalidate (apache#8621)" This reverts commit 4678ae3 Revert "TSHttpTxnCacheLookupStatusGet: call need_to_revalidate (apache#8617)" This reverts commit 235c44a. Revert "TSHttpTxnCacheLookupStatusGet: handle cannot respond cases (apache#8545)" This reverts commit 080e236.
Merged
bneradt
added a commit
that referenced
this pull request
Jan 31, 2022
Fixing #8539 is easy to do in a common case, but it causing issues in corner cases. For now I'm going to revert the fixes for this and circle back around later to see whether this can be solved in a different way. This reverts the following commits: Revert "Commenting TSHttpTxnCacheLookupStatusGet need_to_revalidate (#8621)" This reverts commit 4678ae3 Revert "TSHttpTxnCacheLookupStatusGet: call need_to_revalidate (#8617)" This reverts commit 235c44a. Revert "TSHttpTxnCacheLookupStatusGet: handle cannot respond cases (#8545)" This reverts commit 080e236.
Contributor
Author
|
Adding the 9.2.x project as this will be reverted in 9.2.x when this is cherry-picked back: |
zwoop
pushed a commit
that referenced
this pull request
Feb 2, 2022
Fixing #8539 is easy to do in a common case, but it causing issues in corner cases. For now I'm going to revert the fixes for this and circle back around later to see whether this can be solved in a different way. This reverts the following commits: Revert "Commenting TSHttpTxnCacheLookupStatusGet need_to_revalidate (#8621)" This reverts commit 4678ae3 Revert "TSHttpTxnCacheLookupStatusGet: call need_to_revalidate (#8617)" This reverts commit 235c44a. Revert "TSHttpTxnCacheLookupStatusGet: handle cannot respond cases (#8545)" This reverts commit 080e236. (cherry picked from commit 2f1bd0f)
moonchen
pushed a commit
to moonchen/trafficserver
that referenced
this pull request
Mar 17, 2022
* asf/9.2.x: Updated ChangeLog Add SSLSessionDup for older OpenSSL and BoringSSL (apache#8578) use shared pointer to help with high memory utilization (apache#8498) Commenting TSHttpTxnCacheLookupStatusGet need_to_revalidate (apache#8621) check size of session, and free sessions the ATS way (apache#8330) free sessions when timeout (apache#8356) Fix 32bit build failure on Odroid Xu-4 (apache#8626) TSHttpTxnCacheLookupStatusGet: call need_to_revalidate (apache#8617) SNIConfig (tunnel_route): Change the way we extract matched subgroups from the server name. (apache#8589) fix for collapsed forwarding ink_abort for CacheHitFresh fail (apache#8613) Do not turn off cache for internal requests (apache#8266) Rate Limit Plugin: Re-enable VConnection when SNI is empty (apache#8625) Removes hard dependency on having perl installed (apache#8611)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #8545 and instead directly calls
HttpTransact::need_to_revalidate in TSHttpTxnCacheLookupStatusGet to
ensure that an object which is a cache hit is indeed something ATS can
return to the client.
Fixes #8616
For Review:
This fixes the cache-request-method.test.py AuTest which is currently failing CI for master. Most of this change simply reverts #8545. The only real change is calling need_to_revalidate in InkAPI.cc in TSHttpTxnCacheLookupStatusGet.