Fix 32bit build failure on Odroid Xu-4 #8626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Randy DuCharme <radio.ad5gb@gmail.com>
bneradt
approved these changes
Jan 21, 2022
ywkaras
reviewed
Jan 21, 2022
| ret_val = -1; | ||
| } else { | ||
| if (limit_data.rlim_cur != static_cast<rlim_t> RLIM_INFINITY) { | ||
| if (limit_data.rlim_cur != static_cast<rlim_t>(RLIM_INFINITY)) { |
Contributor
There was a problem hiding this comment.
Thanks, this is good code cleanup in general. I think the only reason it hasn't broken for x86 build is that RLIM_INFINITY is implemented as macro with parentheses enclosing the value:
# define RLIM_INFINITY ((__rlim_t) -1)
Contributor
There was a problem hiding this comment.
Ah, thanks @ywkaras. I was wondering how this built before.
ywkaras
approved these changes
Jan 21, 2022
zwoop
pushed a commit
that referenced
this pull request
Jan 25, 2022
Signed-off-by: Randy DuCharme <radio.ad5gb@gmail.com> (cherry picked from commit 8ac10d5)
Contributor
|
Cherry-picked to v9.2.x |
moonchen
pushed a commit
to moonchen/trafficserver
that referenced
this pull request
Mar 17, 2022
* asf/9.2.x: Updated ChangeLog Add SSLSessionDup for older OpenSSL and BoringSSL (apache#8578) use shared pointer to help with high memory utilization (apache#8498) Commenting TSHttpTxnCacheLookupStatusGet need_to_revalidate (apache#8621) check size of session, and free sessions the ATS way (apache#8330) free sessions when timeout (apache#8356) Fix 32bit build failure on Odroid Xu-4 (apache#8626) TSHttpTxnCacheLookupStatusGet: call need_to_revalidate (apache#8617) SNIConfig (tunnel_route): Change the way we extract matched subgroups from the server name. (apache#8589) fix for collapsed forwarding ink_abort for CacheHitFresh fail (apache#8613) Do not turn off cache for internal requests (apache#8266) Rate Limit Plugin: Re-enable VConnection when SNI is empty (apache#8625) Removes hard dependency on having perl installed (apache#8611)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's and oddball device but ATS now builds and runs well on it.
Also built and tested on OpenSuSE Tumbleweed, Fedora-35 and Centos-8 aarch64 and x86_64 platforms.
Signed-off-by: Randy DuCharme radio.ad5gb@gmail.com