Skip to content

Fix 32bit build failure on Odroid Xu-4 #8626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bneradt merged 1 commit into from
Jan 21, 2022
Merged

Fix 32bit build failure on Odroid Xu-4 #8626

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion proxy/logging/LogUtils.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,7 +599,7 @@ LogUtils::file_is_writeable(const char *full_filename, off_t *size_bytes, bool *
if (e < 0) {
ret_val = -1;
} else {
if (limit_data.rlim_cur != static_cast<rlim_t> RLIM_INFINITY) {
if (limit_data.rlim_cur != static_cast<rlim_t>(RLIM_INFINITY)) {
Copy link
Contributor

@ywkaras ywkaras Jan 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is good code cleanup in general. I think the only reason it hasn't broken for x86 build is that RLIM_INFINITY is implemented as macro with parentheses enclosing the value:

# define RLIM_INFINITY ((__rlim_t) -1)

Copy link
Contributor

@bneradt bneradt Jan 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks @ywkaras. I was wondering how this built before.

if (has_size_limit) {
*has_size_limit = true;
}
Expand Down